This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
PR24125, Assertion failure with embedded NULs in string
- From: Alan Modra <amodra at gmail dot com>
- To: binutils at sourceware dot org
- Date: Fri, 25 Jan 2019 09:44:04 +1030
- Subject: PR24125, Assertion failure with embedded NULs in string
An assertion that can be triggered by user input is wrong, so remove
it. I believe the embedded NUL would have been accepted before the
PR20902 patch, but that seems like a misfeature to me.
PR 20902
PR 24125
* read.c (stringer): Delete assertion.
diff --git a/gas/read.c b/gas/read.c
index 3c84d4388c..228fe7a240 100644
--- a/gas/read.c
+++ b/gas/read.c
@@ -5364,8 +5364,6 @@ stringer (int bits_appendzero)
if (append_zero)
stringer_append_char (0, bitsize);
- know (input_line_pointer[-1] == '\"');
-
#if !defined(NO_LISTING) && defined (OBJ_ELF)
/* In ELF, when gcc is emitting DWARF 1 debugging output, it
will emit .string with a filename in the .debug section
--
Alan Modra
Australia Development Lab, IBM