This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Don't emit vendor attribute section if there is no attribute need to emit.

From: Jim Wilson <jimw at sifive dot com>
To: Kito Cheng <kito dot cheng at gmail dot com>
Cc: "Joseph S. Myers" <joseph at codesourcery dot com>, Binutils <binutils at sourceware dot org>
Date: Mon, 14 Jan 2019 20:38:34 -0800
Subject: Re: [PATCH] Don't emit vendor attribute section if there is no attribute need to emit.
References: <CA+yXCZDzrJrvZTxoWiu=B70fW_Wbx-DcrK+0EsQHcLSz+LxhWA@mail.gmail.com> <CAFyWVaaGb6CUykUZxCt23qdgsy5Gh1Zx-XY3fkgsjtekEYWpoA@mail.gmail.com> <CA+yXCZBiiJ-wjOEtuROh4mTKECU5g0MFaN7DhQ91QV=3vSrLQA@mail.gmail.com> <CAFyWVabuttZD_h2NJfZdaUq+iHasWbgUwtKsxe799sex+W0Rwg@mail.gmail.com>

On Mon, Jan 14, 2019 at 4:52 PM Jim Wilson <jimw@sifive.com> wrote:
> OBJ_ATTR_PROC is over conservative, and can be safely removed.  We do
> need to verify this by checking every target that supports a target
> dependent attribute with this patch.  That is arc, arm, msp430, and
> tic6x.

I tested these four targets with and without the patch and didn't see
any problem.  I also checked the source code, and I don't see any way
to get a zero size attribute section from them, so they can't be
affected by the patch.

This is OK to apply.

Jim

References:
- [PATCH] Don't emit vendor attribute section if there is no attribute need to emit.
  - From: Kito Cheng
- Re: [PATCH] Don't emit vendor attribute section if there is no attribute need to emit.
  - From: Jim Wilson
- Re: [PATCH] Don't emit vendor attribute section if there is no attribute need to emit.
  - From: Kito Cheng
- Re: [PATCH] Don't emit vendor attribute section if there is no attribute need to emit.
  - From: Jim Wilson

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]