This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [Patch] multibyte encodings in strings
- From: Nick Clifton <nickc at redhat dot com>
- To: Alan Modra <amodra at gmail dot com>, m4tze at exitno dot de
- Cc: binutils at sourceware dot org
- Date: Mon, 10 Dec 2018 10:40:32 +0000
- Subject: Re: [Patch] multibyte encodings in strings
- References: <20181030110408.GA3348@exitno.de> <e7a9b342-166c-ed63-8184-62756bafba05@redhat.com> <20181208025050.GM29034@bubble.grove.modra.org>
Hi Alan,
> Yeah, the output should be exactly "String1\nString2". Anything else
> is broken. I saw a blank line output before the expected output, and
> in one other instance:
>
> in
> String1
> String2
>
> git commit 71f5e3f7b624 obviously wasn't tested on a big-endian host,
> and the test fail message resulted in tcl errors. This patch should
> fix the issues I found.
>
> * strings.c (unget_part_char): New function.
> (print_strings): Use unget_part_char. Formatting.
> * testsuite/binutils-all/strings.exp (test_multibyte): Don't
> use square brackets in fail message. Expect "String1\nString2".
Thanks for fixing this. :-)
Cheers
Nick