This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Fwd: [PATCH] elf: Report property change when merging properties
- From: Nick Clifton <nickc at redhat dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>, "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Fri, 7 Dec 2018 16:23:36 +0000
- Subject: Re: Fwd: [PATCH] elf: Report property change when merging properties
- References: <20181122184835.25437-1-hjl.tools@gmail.com> <20181126001549.GS21617@bubble.grove.modra.org> <CAMe9rOq-x82Eo5J63WGkGpH6ots_6bQvv3U4e5L1Os5+uydyPg@mail.gmail.com> <2c601560-3b6e-1b40-5706-57a15566bc5a@redhat.com> <CAMe9rOqg73Risx1f4WQ6ZyWDSATQ2mjo-P1NGfVURM1WYc5M=g@mail.gmail.com> <CAJimCsFZPadaQOS8r5RfPjs75h7kmR=D_gFUc_1u96MPK7i7hQ@mail.gmail.com> <CAMe9rOo=gYa-ewOO2Gg=Hi__gWiVwO8MRzKBLSP6yQNY=Y1W9Q@mail.gmail.com> <CAJimCsFdeBFYq85vuYcoL3fS7wfiDVHwO83VoO=sf+TW1R9EWg@mail.gmail.com> <CAMe9rOohL_91PBSS++pBEhnJxO8fPDGXkMDx6t=AaU3WUGQL6Q@mail.gmail.com> <20181202234308.GA7274@gmail.com> <CAMe9rOq_=2j9nLjPuUZF0rsDeh_gGhNomuWMpqQHt9ZOapcFrw@mail.gmail.com>
Hi H.J.
> Here is the updated patch to cut down noises. Now it generates:
>
> Mering program properties
>
> Removed property 0xc0010000 to merge
> /usr/lib/gcc/x86_64-redhat-linux/8/../../../../lib64/crt1.o (0x0) and
> /usr/lib/gcc/x86_64-redhat-linux/8/../../../../lib64/crti.o (0x0)
> Removed property 0xc0000002 to merge
> /usr/lib/gcc/x86_64-redhat-linux/8/../../../../lib64/crt1.o (0x3) and
> x.o (not found)
> Removed property 0xc0000000 to merge
> /usr/lib/gcc/x86_64-redhat-linux/8/../../../../lib64/crt1.o (not
> found) and /usr/lib64/libc_nonshared.a(elf-init.oS) (0x0)
> Removed property 0xc0000001 to merge
> /usr/lib/gcc/x86_64-redhat-linux/8/../../../../lib64/crt1.o (not
> found) and /usr/lib64/libc_nonshared.a(elf-init.oS) (0x0)
That is much nicer.
> OK for trunk?
> * elf-properties.c (elf_find_and_remove_property): Add a
> bfd_boolean argument to indicate if the property should be
> removed.
> (elf_merge_gnu_property_list): Updated. Report
> property change in linker map file.
> (elf_get_gnu_property_section_size): Skip property_remove
> properties.
> (elf_write_gnu_properties): Likewise.
> (_bfd_elf_link_setup_gnu_properties): Report property merge
> in linker map file. Pass abfd to elf_merge_gnu_property_list.
>
> include/
>
> * bfdlink.h (bfd_link_info): Add has_map_file.
>
> ld/
>
> * NEWS: Updated for property change report.
> * ld.texi: Document property change report.
> * ldmain.c (main): Set link_info.has_map_file to TRUE when
> linker map file is used.
> * testsuite/ld-x86-64/property-x86-ibt1a-x32.d: Check linker map
> file.
> * testsuite/ld-x86-64/property-x86-ibt1a.d: Likewise.
> * testsuite/ld-x86-64/property-x86-ibt1a.map: New file.
Approved - please apply.
Cheers
Nick