This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH][GAS][MSP430] Improve NOP warnings/insertion behaviour around interrupt state changes
- From: Jozef Lawrynowicz <jozef dot l at mittosystems dot com>
- To: Nick Clifton <nickc at redhat dot com>
- Cc: binutils at sourceware dot org
- Date: Tue, 27 Nov 2018 15:58:30 +0000
- Subject: Re: [PATCH][GAS][MSP430] Improve NOP warnings/insertion behaviour around interrupt state changes
- References: <20181125132704.49071042@jozef-Aspire-VN7-793G> <a7b23c16-6757-a848-0005-03410f071617@redhat.com>
On Tue, 27 Nov 2018 12:30:44 +0000
Nick Clifton <nickc@redhat.com> wrote:
> Approved and applied.
Hi Nick,
Thanks for the review.
> > diff --git a/gas/config/tc-msp430.c b/gas/config/tc-msp430.c
> [...]
> > @@ -2654,37 +2733,76 @@ msp430_operands (struct msp430_opcode_s * opcode, char * line)
> [...]
> >
> > - if (gen_interrupt_nops)
> > - /* Emit a NOP between interrupt enable/disable.
> > - See 1.3.4.1 of the MSP430x5xx User Guide. */
> > - doit = TRUE;
> > - break;
> > -
> > case NOP_CHECK_CPU12:
>
> This deleted the "break" statement at the end of NOP_CHECK_INTERRUPT case.
> I assumed that your intent was not to fall through into the NOP_CHECK_CPU12
> case, so I restored the break statement.
>
Ah yes, that was a mistake, thanks for fixing it.
Jozef