This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/2] Allow to override build date with SOURCE_DATE_EPOCH


On Wed, Oct 31, 2018 at 10:50:07AM +0100, Bernhard M. Wiedemann wrote:
     On 26/10/2018 12.54, John Darrington wrote:
     > I don't agree that this is an elegant solution to the problem.
     > 
     > SOURCE_DATE_EPOCH is a hack at best, to be used when there is no other
     > practical way to solve the problem.
     > 
     > Binutils already has a --enable-deterministic-archives option so we
     > should use that instead.
     
     I still would like some nice solution be merged. If you know a better
     way, than my patch, I'd like to test that.
     
     enable-deterministic-archives is not even related to this, so may want
     to have another look.


Hi Bernhard,


I don't think  the decision is mine to make.   I was simply voicing an 
opinion.

I agree that the name of the option --enable-deterministic-archives is
too specific to logically include this change.   I would be in favour of
a new option for binutils: --enable-deterministic   which by default 
would imply --enable-deterministic-archives

I would be suprised if, in the future, no other sources of non-determinism
are discovered.  So I think an option which can cover them all would
be the best way to go.

J'


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]