This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [GAS][ARM] Fix failing Armv1 test
- From: Ramana Radhakrishnan <ramana dot gcc at googlemail dot com>
- To: Andre Vieira <Andre dot SimoesDiasVieira at arm dot com>
- Cc: binutils <binutils at sourceware dot org>
- Date: Tue, 30 Oct 2018 15:32:38 +0000
- Subject: Re: [GAS][ARM] Fix failing Armv1 test
- References: <5BC9F176.4010201@arm.com>
On Fri, Oct 19, 2018 at 4:01 PM Andre Vieira (lists)
<Andre.SimoesDiasVieira@arm.com> wrote:
>
> Hi,
>
> This patch fixes a testism. This test has been failing for a while and
> it could be argued that since we started testing 'arm7t' here (and not
> Armv1) the test itself was wrong. So I changed the assembly to Armv1.
> Given the changes to objdump when "disassembling all" it seemed like a
> good idea to force the disassembly to 'armv2' instead and actually
> accept the disassembly of the 26-bit Architecture variants of tst, teq,
> cmn and cmp.
>
> Is this OK for trunk?
>
Ok,
At some point I would like to consider moving gas up to armv4 as well
in line with gcc but it will take a long(er) time.
Ramana
> gas/ChangeLog
>
> 2018-10-19 Andre Vieira <andre.simoesdiasvieira@arm.com>
>
> * testsuite/gas/arm/armv1.d: Assemble for Armv1
> and disassemble for Armv2-