This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [GAS][ARM] Fix failing Armv1 test
- From: Thomas Preudhomme <thomas dot preudhomme at linaro dot org>
- To: Andre dot SimoesDiasVieira at arm dot com
- Cc: binutils at sourceware dot org
- Date: Fri, 26 Oct 2018 11:40:39 +0100
- Subject: Re: [GAS][ARM] Fix failing Armv1 test
- References: <5BC9F176.4010201@arm.com>
Hi Andre,
Thanks for doing this. The change looks good to me but I'm not a
maintainer so you'll not someone else to approve.
Best regards,
Thomas
On Fri, 19 Oct 2018 at 16:01, Andre Vieira (lists)
<Andre.SimoesDiasVieira@arm.com> wrote:
>
> Hi,
>
> This patch fixes a testism. This test has been failing for a while and
> it could be argued that since we started testing 'arm7t' here (and not
> Armv1) the test itself was wrong. So I changed the assembly to Armv1.
> Given the changes to objdump when "disassembling all" it seemed like a
> good idea to force the disassembly to 'armv2' instead and actually
> accept the disassembly of the 26-bit Architecture variants of tst, teq,
> cmn and cmp.
>
> Is this OK for trunk?
>
> gas/ChangeLog
>
> 2018-10-19 Andre Vieira <andre.simoesdiasvieira@arm.com>
>
> * testsuite/gas/arm/armv1.d: Assemble for Armv1
> and disassemble for Armv2-