This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [GAS][ARM] Fix UDF testism


Hi Andre,

I'm not a maintainer but I have one comment nonetheless: I'd suggest
using the 0+ notation to absorb all the 0s in the address prefix to be
consistent with the rest of the testsuite (see eg.
gas/testsuite/gas/arm/arch6zk.d as a random example).

Looks good to me otherwise. Best regards,

Thomas
On Fri, 19 Oct 2018 at 16:00, Andre Vieira (lists)
<Andre.SimoesDiasVieira@arm.com> wrote:
>
> Hi,
>
> This patch fixes a testism.
> The old test never checked the objdump output since the 'error-output'
> directive
> would exit and thus never run objdump.  When this test was changed to
> adhere to
> use the new warning_output we started to run objdump.  The expected objdump
> output was old and had bitrotten, this fixes the layout, as the
> "disassembly"
> itself did not change.
>
> Is this OK for trunk?
>
> 2018-10-19  Andre Vieira  <andre.simoesdiasvieira@arm.com>
>
>         * testsuite/gas/arm/udf.d: Update expected output.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]