This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH][Binutils][Arm] Fix disassembler crashing on -b binary when thumb file and thumb not forced.
- From: Christophe Lyon <christophe dot lyon at linaro dot org>
- To: nick clifton <nickc at redhat dot com>
- Cc: Tamar Christina <tamar dot christina at arm dot com>, binutils <binutils at sourceware dot org>, nd <nd at arm dot com>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, Ramana Radhakrishnan <ramana dot radhakrishnan at arm dot com>
- Date: Fri, 19 Oct 2018 14:44:36 +0200
- Subject: Re: [PATCH][Binutils][Arm] Fix disassembler crashing on -b binary when thumb file and thumb not forced.
- References: <20181017161810.GA16924@arm.com> <fca9f107-a08a-98b1-2fdd-12b96d6ed6c3@redhat.com>
Hi Tamar,
On Thu, 18 Oct 2018 at 18:18, Nick Clifton <nickc@redhat.com> wrote:
>
> Hi Tamar,
>
> > gas/ChangeLog:
> > 2018-10-17 Tamar Christina <tamar.christina@arm.com>
> >
> > * testsuite/gas/arm/undefined-insn-arm.d: New test.
> > * testsuite/gas/arm/undefined-insn-thumb.d: New test.
> > * testsuite/gas/arm/undefined-insn.s: New test.
> >
> > opcodes/ChangeLog:
> > 2018-10-17 Tamar Christina <tamar.christina@arm.com>
> >
> > * arm-dis.c (UNKNOWN_INSTRUCTION_32BIT): Format specifier for arm mode.
> > (UNKNOWN_INSTRUCTION_16BIT): Format specifier for thumb mode.
> > (print_insn_arm, print_insn_thumb16, print_insn_thumb32): Use them.
>
> Approved - please apply.
>
> Cheers
> Nick
>
>
> PS. Thank you for getting rid of some aborts. Personally, I think that
> they are a bad thing to have in a library...
I've noticed regressions after your patch on arm-wince-pe:
FAIL: gas:Undefined binary printing in arm mode
FAIL: gas:Undefined binary printing in thumb mode
Christophe