This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] [objcopy] Return a fatal error when --keep-global-symbol(s) is used with --globalize-symbols, since it is an error prone pattern.
- From: Nick Clifton <nickc at redhat dot com>
- To: Jordan Rupprecht <rupprecht at google dot com>
- Cc: echristo at gmail dot com, binutils at sourceware dot org
- Date: Thu, 11 Oct 2018 11:44:43 +0100
- Subject: Re: [PATCH] [objcopy] Return a fatal error when --keep-global-symbol(s) is used with --globalize-symbols, since it is an error prone pattern.
- References: <20181009211616.190098-1-rupprecht@google.com>
Hi Jordan,
Thanks very much for the patch. It is fine, and I have applied it
to the binutils sources. I did make a couple of additions:
* I updated the documentation to mention that the two options should
not be used together.
* I added a test to the binutils testsuite to make sure that the
error message is produced.
* I created an entry in the binutils/ChangeLog file describing the
patch.
Cheers
Nick
PS. Since the patch was quite simple, I have treated it as "obvious"
which means that you do not need a FSF copyright assignment. If
however in the future you wish to contribute bigger patches - and I
hope that you will - then you will need a copyright assignment in
place.