This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH, BINUTILS, ARM, 1/3] Add -march=armv8.5-a and related internal feature macros to AArch32
- From: "Richard Earnshaw (lists)" <Richard dot Earnshaw at arm dot com>
- To: Sudakshina Das <sudi dot das at arm dot com>, "binutils at sourceware dot org" <binutils at sourceware dot org>
- Cc: nd <nd at arm dot com>, Ramana Radhakrishnan <Ramana dot Radhakrishnan at arm dot com>, Nick Clifton <nickc at redhat dot com>
- Date: Fri, 5 Oct 2018 11:32:16 +0100
- Subject: Re: [PATCH, BINUTILS, ARM, 1/3] Add -march=armv8.5-a and related internal feature macros to AArch32
- References: <1fcaf08f-af99-9151-53d1-6258b5c22af8@arm.com>
On 19/09/18 15:35, Sudakshina Das wrote:
> Hi
>
> Thia patch is part of the patch series to add support for ARMv8.5-A
> extensions.
> (https://developer.arm.com/products/architecture/cpu-architecture/a-profile/exploration-tools)
>
>
> This is the first of the patch series and adds -march=armv8.5-a and
> other internal feature marcos needed for it.
>
> Testing done: Builds and reg tests all pass on arm-none-eabi and
> added new test.
>
> Ok for trunk?
>
Applied, thanks.
R.
> Thanks
> Sudi
> PS. I do not have commit access so if OK can someone apply for me?
>
>
> *** gas/ChangeLog ***
>
> 2018-xx-xx Sudakshina Das <sudi.das@arm.com>
>
> * config/tc-arm.c (arm_archs): New entry for armv8.5-a.
> (cpu_arch_ver): Likewise.
> * doc/c-arm.texi: Add documentation for the same.
> * testsuite/gas/arm/attr-march-armv8_5-a.d: New.
>
> *** include/ChnageLog ***
>
> 2018-xx-xx Sudakshina Das <sudi.das@arm.com>
>
> * opcode/arm.h (ARM_EXT2_V8_5A): New.
> (ARM_AEXT2_V8_5A, ARM_ARCH_V8_5A): New.
>
>
>
> rb9972.patch
>
>
> diff --git a/gas/config/tc-arm.c b/gas/config/tc-arm.c
> index 3f5384e1c719de9fedf5a753abbe66c29a2e2afb..ef3af3a0110398b5ddb1c77856a9db895ef90fd1 100644
> --- a/gas/config/tc-arm.c
> +++ b/gas/config/tc-arm.c
> @@ -26335,6 +26335,7 @@ static const struct arm_arch_option_table arm_archs[] =
> ARM_ARCH_OPT ("armv8.3-a", ARM_ARCH_V8_3A, FPU_ARCH_VFP),
> ARM_ARCH_OPT ("armv8-r", ARM_ARCH_V8R, FPU_ARCH_VFP),
> ARM_ARCH_OPT ("armv8.4-a", ARM_ARCH_V8_4A, FPU_ARCH_VFP),
> + ARM_ARCH_OPT ("armv8.5-a", ARM_ARCH_V8_5A, FPU_ARCH_VFP),
> ARM_ARCH_OPT ("xscale", ARM_ARCH_XSCALE, FPU_ARCH_VFP),
> ARM_ARCH_OPT ("iwmmxt", ARM_ARCH_IWMMXT, FPU_ARCH_VFP),
> ARM_ARCH_OPT ("iwmmxt2", ARM_ARCH_IWMMXT2,FPU_ARCH_VFP),
> @@ -27046,6 +27047,7 @@ static const cpu_arch_ver_table cpu_arch_ver[] =
> {TAG_CPU_ARCH_V8M_MAIN, ARM_ARCH_V8M_MAIN},
> {TAG_CPU_ARCH_V8R, ARM_ARCH_V8R},
> {TAG_CPU_ARCH_V8, ARM_ARCH_V8_4A},
> + {TAG_CPU_ARCH_V8, ARM_ARCH_V8_5A},
> {-1, ARM_ARCH_NONE}
> };
>
> diff --git a/gas/doc/c-arm.texi b/gas/doc/c-arm.texi
> index a316c267e22c603ed529451a488d9b3d1baf5c56..522a1dbbba5aa23947e38b2fdbd8880a31ce7f0f 100644
> --- a/gas/doc/c-arm.texi
> +++ b/gas/doc/c-arm.texi
> @@ -241,6 +241,7 @@ names are recognized:
> @code{armv8.3-a},
> @code{armv8-r},
> @code{armv8.4-a},
> +@code{armv8.5-a},
> @code{iwmmxt}
> @code{iwmmxt2}
> and
> diff --git a/gas/testsuite/gas/arm/attr-march-armv8_5-a.d b/gas/testsuite/gas/arm/attr-march-armv8_5-a.d
> new file mode 100644
> index 0000000000000000000000000000000000000000..70b6074e48fab2aeb5acda4641ef95f4a0688972
> --- /dev/null
> +++ b/gas/testsuite/gas/arm/attr-march-armv8_5-a.d
> @@ -0,0 +1,17 @@
> +# name: attributes for -march=armv8.5-a
> +# source: blank.s
> +# as: -march=armv8.5-a
> +# readelf: -A
> +# This test is only valid on EABI based ports.
> +# target: *-*-*eabi* *-*-nacl*
> +
> +Attribute Section: aeabi
> +File Attributes
> + Tag_CPU_name: "8.5-A"
> + Tag_CPU_arch: v8
> + Tag_CPU_arch_profile: Application
> + Tag_ARM_ISA_use: Yes
> + Tag_THUMB_ISA_use: Thumb-2
> + Tag_Advanced_SIMD_arch: NEON for ARMv8.1
> + Tag_MPextension_use: Allowed
> + Tag_Virtualization_use: TrustZone and Virtualization Extensions
> diff --git a/include/opcode/arm.h b/include/opcode/arm.h
> index 83b3f22c68fff11edda12a9a0312bfd45e3d0dda..bad131e51c5d84e30dcf32a8242a455749ae3d8a 100644
> --- a/include/opcode/arm.h
> +++ b/include/opcode/arm.h
> @@ -68,6 +68,7 @@
> #define ARM_EXT2_V8A 0x00000200 /* ARMv8-A. */
> #define ARM_EXT2_V8_4A 0x00000400 /* ARM V8.4A. */
> #define ARM_EXT2_FP16_FML 0x00000800 /* ARM V8.2A FP16-FML instructions. */
> +#define ARM_EXT2_V8_5A 0x00001000 /* ARM V8.5A. */
>
> /* Co-processor space extensions. */
> #define ARM_CEXT_XSCALE 0x00000001 /* Allow MIA etc. */
> @@ -159,6 +160,7 @@
> #define ARM_AEXT2_V8_2A (ARM_AEXT2_V8_1A | ARM_EXT2_V8_2A | ARM_EXT2_RAS)
> #define ARM_AEXT2_V8_3A (ARM_AEXT2_V8_2A | ARM_EXT2_V8_3A)
> #define ARM_AEXT2_V8_4A (ARM_AEXT2_V8_3A | ARM_EXT2_FP16_FML | ARM_EXT2_V8_4A)
> +#define ARM_AEXT2_V8_5A (ARM_AEXT2_V8_4A | ARM_EXT2_V8_5A)
> #define ARM_AEXT_V8M_BASE (ARM_AEXT_V6SM | ARM_EXT_DIV)
> #define ARM_AEXT_V8M_MAIN ARM_AEXT_V7M
> #define ARM_AEXT_V8M_MAIN_DSP ARM_AEXT_V7EM
> @@ -293,6 +295,9 @@
> #define ARM_ARCH_V8_4A ARM_FEATURE (ARM_AEXT_V8A, ARM_AEXT2_V8_4A, \
> CRC_EXT_ARMV8 | FPU_NEON_EXT_RDMA \
> | FPU_NEON_EXT_DOTPROD)
> +#define ARM_ARCH_V8_5A ARM_FEATURE (ARM_AEXT_V8A, ARM_AEXT2_V8_5A, \
> + CRC_EXT_ARMV8 | FPU_NEON_EXT_RDMA \
> + | FPU_NEON_EXT_DOTPROD)
> #define ARM_ARCH_V8M_BASE ARM_FEATURE_CORE (ARM_AEXT_V8M_BASE, ARM_AEXT2_V8M)
> #define ARM_ARCH_V8M_MAIN ARM_FEATURE_CORE (ARM_AEXT_V8M_MAIN, \
> ARM_AEXT2_V8M_MAIN)
>
>