This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/3] ELF: Group PT_NOTE segments by section alignments

Hi H.J.

>> I did not think that note sections were required to have a ".note"
>> prefix to their name.  So wouldn't it be better to check for a SHF_NOTE
>> flag instead ?  (Assuming that the section is in an ELF format bfd, of
>> course).

> get_program_header_size and _bfd_elf_map_sections_to_segments are only
> used on ELF files.

I suspected as much, but I was being paranoid.  And also too lazy to check
the code for myself...

> This updated patch checks SHT_NOTE section type instead.
> OK for master?

Approved -please apply.

Cheers
  Nick
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]