This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 0/3] MIPS/GAS: Extend the R5900 short loop fix test and notes
- From: "Maciej W. Rozycki" <macro at linux-mips dot org>
- To: Fredrik Noring <noring at nocrew dot org>
- Cc: Chenghua Xu <paul dot hua dot gm at gmail dot com>, binutils at sourceware dot org, Jürgen Urban <JuergenUrban at gmx dot de>
- Date: Sun, 30 Sep 2018 15:01:53 +0100 (BST)
- Subject: Re: [PATCH 0/3] MIPS/GAS: Extend the R5900 short loop fix test and notes
- References: <cover.1538299772.git.noring@nocrew.org>
Hi Fredrik,
> This set of changes clarifies the conditions for the R5900 short loop fix
> and extends its test with the border cases of six and seven instructions.
Thank you for your contribution. These changes look OK to me, but can
you please reformat comments and change descriptions to fit in 74 columns
(as per
<https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards#Formatting_Your_Code>;
this is from our sister project's wiki as we haven't grown our own one
yet, but the projects share both code and the repository, and the rules
are roughly the same).
Also this is your first submission and these changes are substantial
enough to require a copyright assignment or a similar arrangement with
FSF. Can you please clarify if you have one in place?
Maciej