Re: [PATCH 0/13] [NDS32] Update and support more target features for the nds32 port

[Nick Clifton <nickc at redhat dot com>]

Hi Nelson,

  Thank you very much for submitting this patch series.

  I did encounter a couple of problems building the patched files however:

bfd/elf32-nds32.c: In function 'nds32_elf_relax_section':
bfd/elf32-nds32.c:12241:37: error: bitwise comparison always evaluates to false [-Werror=tautological-compare]
       || (sec->flags & SEC_EXCLUDE) == 1
                                     ^~
  and:

bfd/elf32-nds32.c: In function 'nds32_elf_relocate_section':
bfd/elf32-nds32.c:5271:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
        if (strcmp (elf_sym_hashes (input_bfd)[symndx]->root.root.string,
           ^
bfd/elf32-nds32.c:5283:6: note: here
      case R_NDS32_SDA19S0_RELA:
      ^~~~

  This is with gcc v 8.1.1 on a Fedora 28 box.  They should be very easy to fix.


  I also see two regressions in the binutils testsuite with the patches applied:

    Checking Binutils in: nds32le-elf ... GAS: 8  LD: 22  BIN: 7  done
     BIN REGRESSION: binutils-all/strip-13    
     BIN REGRESSION: readelf -r bintest  

  The strip 13 regression is because:

    succeeded with: <>, expected: <\A[^\n]*: unsupported relocation type 0x[0-9a-f]+\n[^\n]*: bad value\Z>
    FAIL: binutils-all/strip-13

  So you may need to patch binutils/testsuite/binutils-all/objcopy.exp and
  choose a different number for the "unsupported" reloc when running the
  strip-13 test for the NDS.  (See the code immediately following which does
  something similar for the strip-14 test).

  For the "readelf -r bintest" case, it looks like you will need to amend
  binutils/testsuite/binutils-all/readelf.r.  There is already some NDS specific
  code in there.  You will probably need to add some more.

  (As a general guideline, please run all of the binutils testsuites before
  submitting a patch, and check/fix any regressions).


  One other thing, in the future, please could you provide the
  changelog entries as plain text, rather than as part of the
  diff.  The problem is that the changelogs change so frequntly
  that the diffs almost never apply.  In fact when I was applying
  the patch series, every single one of them failed because the
  changelog frags would not apply.

Cheers
  Nick