This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Fix PR gdb/20948: --write option to GDB causes segmentation fault
- From: Tom Tromey <tom at tromey dot com>
- To: Jozef Lawrynowicz <jozef dot l at mittosystems dot com>
- Cc: binutils at sourceware dot org
- Date: Mon, 17 Sep 2018 10:13:51 -0600
- Subject: Re: [PATCH] Fix PR gdb/20948: --write option to GDB causes segmentation fault
- References: <de92821f-91d2-8058-bc51-2df7bed30191@mittosystems.com>
>>>>> "Jozef" == Jozef Lawrynowicz <jozef.l@mittosystems.com> writes:
Jozef> The PR is assigned to GDB, but the fix is to BFD, hence the
Jozef> submission to binutils mailing list instead of GDB.
Jozef> * gdb/testsuite/gdb.base/write_mem.exp: New test.
Jozef> * gdb/testsuite/gdb.base/write_mem.c: Likewise.
The ChangeLog entries have to be split into the appropriate directories.
Jozef> diff --git a/gdb/testsuite/gdb.base/write_mem.c b/gdb/testsuite/gdb.base/write_mem.c
Jozef> new file mode 100644
Jozef> index 0000000..941f172
Jozef> --- /dev/null
Jozef> +++ b/gdb/testsuite/gdb.base/write_mem.c
Jozef> @@ -0,0 +1,7 @@
Jozef> +/* Test for PR gdb/20948. */
Both new gdb files need the GPL header.
You can copy one from some other test file.
Jozef> +if {[build_executable $testfile.exp $testfile \
Jozef> + $srcfile [list debug nowarnings] ] == -1} {
The indentation of this line looks off to me.
I would suggest checking other examples to see how it should look.
This is ok with these things fixed. Thank you for the patch.
Tom