This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] x86: Properly decode EVEX.W in vcvt[u]si2s[sd] in 32-bit
- From: "Jan Beulich" <jbeulich at suse dot com>
- To: <hjl dot tools at gmail dot com>
- Cc: <binutils at sourceware dot org>
- Date: Sun, 16 Sep 2018 02:57:52 -0600
- Subject: Re: [PATCH] x86: Properly decode EVEX.W in vcvt[u]si2s[sd] in 32-bit
- References: <20180914174705.11947-1-hjl.tools@gmail.com>
>>> "H.J. Lu" <hjl.tools@gmail.com> 09/14/18 7:47 PM >>>
>--- /dev/null
>+++ b/gas/testsuite/gas/i386/evex.d
>@@ -0,0 +1,16 @@
>+#objdump: -dw -Msuffix
>+#name: i386 EVX insns
>+
>+.*: +file format .*
>+
>+
>+Disassembly of section .text:
>+
>+0+ <_start>:
>+ +[a-f0-9]+: 62 f1 d6 38 2a f0 vcvtsi2ssl %eax,\{rd-sae\},%xmm5,%xmm6
>+ +[a-f0-9]+: 62 f1 d7 38 2a f0 vcvtsi2sdl %eax,\{rd-sae\},%xmm5,%xmm6
>+ +[a-f0-9]+: 62 f1 d6 08 7b f0 vcvtusi2ssl %eax,%xmm5,%xmm6
>+ +[a-f0-9]+: 62 f1 d7 08 7b f0 vcvtusi2sdl %eax,%xmm5,%xmm6
>+ +[a-f0-9]+: 62 f1 d6 38 7b f0 vcvtusi2ssl %eax,\{rd-sae\},%xmm5,%xmm6
>+ +[a-f0-9]+: 62 f1 d7 38 7b f0 vcvtusi2sdl %eax,\{rd-sae\},%xmm5,%xmm6
Hmm, a new test demanding (according to what you've told me in earlier
discussions) bad behavior: You've said that you don't want suffixes on newer
insns when they're not needed. While these insns may indeed better have
suffixes in 64-bit mode (they strictly need them only with memory operands),
there's clearly nothing to disambiguate in 16- and 32-bit modes. May I ask
for consistency please between what you demand for patches I submit and
ones you commit, once again without even giving a little time for reviews?
Jan