This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Encrypted Message


Hi Paul,

> Please review this series patch.

So sorry - I had become so used to Maciej reviewing these patches
that I just assumed that he would handle this series too.

The patches themselves are fine, but there is one problem - you
need to update the gold linker as well.  This still has references
to the deprecated Loongson3a name and no code for the gs464e or gs264
variants...

Also, with the patches applied I did find a few regressions in some
of the binutils test suites:

Checking Binutils in: mips64-openbsd ... 
  LD REGRESSION: MIPS incompatible objects: "-march=gs464 -32"
  LD REGRESSION: MIPS compatible objects: "-march=gs464 -32"
  LD REGRESSION: MIPS compatible objects: "-march=gs264e -32"

Checking Binutils in: mips64el-openbsd ... 
  LD REGRESSION: MIPS incompatible objects: "-march=gs464 -32"
  LD REGRESSION: MIPS compatible objects: "-march=gs464 -32"
  LD REGRESSION: MIPS compatible objects: "-march=gs264e -32"

Checking Binutils in: mips-sgi-irix6 ... 
  LD REGRESSION: MIPS compatible objects: "-march=gs464 -32"
  LD REGRESSION: MIPS compatible objects: "-march=gs264e -32"

Checking Binutils in: mipsisa32el-linux ... 
  GAS REGRESSION: Loongson CAM tests  
  GAS REGRESSION: Loongson EXT2 tests  

Checking Binutils in: tx39-elf ... 
  GAS REGRESSION: Loongson CAM tests  
  GAS REGRESSION: Loongson EXT2 tests  


Would you mind taking a look at these please ?  I suspect that they
will just turn out to be cases where it is inappropriate to run the
test, but I would like to be sure.

Cheers
  Nick

PS. Are you able to comit patches yourself, or do you need me to do that ?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]