This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[PATCH] bfd/elf-hppa.h: Cleanup constants and comments
- From: Helge Deller <deller at gmx dot de>
- To: binutils at sourceware dot org
- Cc: John David Anglin <dave dot anglin at bell dot net>, Alan Modra <amodra at gmail dot com>
- Date: Tue, 14 Aug 2018 18:08:33 +0200
- Subject: [PATCH] bfd/elf-hppa.h: Cleanup constants and comments
Minor cleanups. Please commit if Ok.
Thanks,
Helge
bfd/
* elf-hppa.h (elf_hppa_fake_sections): Use SHT_PROGBITS instead of "1".
Update comment regarding sh_entsize.
diff --git a/bfd/elf-hppa.h b/bfd/elf-hppa.h
index 5eac12996d..207abc3ff2 100644
--- a/bfd/elf-hppa.h
+++ b/bfd/elf-hppa.h
@@ -1131,9 +1131,9 @@ elf_hppa_fake_sections (bfd *abfd, Elf_Internal_Shdr *hdr, asection *sec)
asection *asec;
#if ARCH_SIZE == 64
- hdr->sh_type = SHT_LOPROC + 1;
+ hdr->sh_type = SHT_LOPROC + SHT_PROGBITS;
#else
- hdr->sh_type = 1;
+ hdr->sh_type = SHT_PROGBITS;
#endif
/* ?!? How are unwinds supposed to work for symbols in arbitrary
sections? Or what if we have multiple .text sections in a single
@@ -1154,7 +1154,7 @@ elf_hppa_fake_sections (bfd *abfd, Elf_Internal_Shdr *hdr, asection *sec)
}
}
- /* I have no idea if this is really necessary or what it means. */
+ /* Size of one unwind table entry is 16 (=2^4) bytes. */
hdr->sh_entsize = 4;
}
return TRUE;