This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[committed, PATCH] Skip PR binutils/23494 tests for nacl targets

From: "H.J. Lu" <hjl dot tools at gmail dot com>
To: Alan Modra <amodra at gmail dot com>
Cc: Binutils <binutils at sourceware dot org>
Date: Fri, 10 Aug 2018 07:57:35 -0700
Subject: [committed, PATCH] Skip PR binutils/23494 tests for nacl targets

On Wed, Aug 8, 2018 at 8:58 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Wed, Aug 8, 2018 at 8:21 PM, Alan Modra <amodra@gmail.com> wrote:
>> On Wed, Aug 08, 2018 at 07:24:33PM -0700, H.J. Lu wrote:
>>> --- a/bfd/bfd.c
>>> +++ b/bfd/bfd.c
>>> @@ -2483,6 +2483,10 @@ bfd_convert_section_size (bfd *ibfd, sec_ptr isec, bfd *obfd,
>>>        == get_elf_backend_data (obfd)->s->elfclass)
>>>      return size;
>>>
>>> +  /* Convert GNU property size.  */
>>> +  if (CONST_STRNEQ (isec->name, NOTE_GNU_PROPERTY_SECTION_NAME))
>>> +    return _bfd_elf_convert_gnu_property_size (ibfd, obfd);
>>> +
>>>    /* Do nothing if the input section isn't a SHF_COMPRESSED section. */
>>>    hdr_size = bfd_get_compression_header_size (ibfd, isec);
>>>    if (hdr_size == 0)
>>
>> I suspect this conversion shouldn't depend on the earlier
>> BFD_DECOMPRESS test, and similarly for convert_section_contents.
>> OK with that fixed.
>>
>
> You are right.  I am checking in this updated patch with a new testcase.
>
> Thanks.
>

I checked in this patch to skip PR binutils/23494 tests for nacl targets.


-- 
H.J.

From 11459a79d97842a64961a35472bb8d67ed0fcf22 Mon Sep 17 00:00:00 2001
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Fri, 10 Aug 2018 07:53:50 -0700
Subject: [PATCH] Skip PR binutils/23494 tests for nacl targets

PR binutils/23494 tests pass "-O elf64-x86-64" and "-O elf32-x86-64"
to objcopy which may not supported for nacl targets.  This patch skips
these tests for nacl targets.

	* testsuite/binutils-all/x86-64/pr23494a-x32.d: Skip nacl
	targets.
	* testsuite/binutils-all/x86-64/pr23494a.d: Likewise.
	* testsuite/binutils-all/x86-64/pr23494b-x32.d: Likewise.
	* testsuite/binutils-all/x86-64/pr23494b.d: Likewise.
	* testsuite/binutils-all/x86-64/pr23494c-x32.d: Likewise.
	* testsuite/binutils-all/x86-64/pr23494c.d: Likewise.
	* testsuite/binutils-all/x86-64/pr23494d-x32.d: Likewise.
	* testsuite/binutils-all/x86-64/pr23494d.d: Likewise.
---
 binutils/ChangeLog                                   | 12 ++++++++++++
 .../testsuite/binutils-all/x86-64/pr23494a-x32.d     |  1 +
 binutils/testsuite/binutils-all/x86-64/pr23494a.d    |  1 +
 .../testsuite/binutils-all/x86-64/pr23494b-x32.d     |  1 +
 binutils/testsuite/binutils-all/x86-64/pr23494b.d    |  1 +
 .../testsuite/binutils-all/x86-64/pr23494c-x32.d     |  1 +
 binutils/testsuite/binutils-all/x86-64/pr23494c.d    |  1 +
 .../testsuite/binutils-all/x86-64/pr23494d-x32.d     |  1 +
 binutils/testsuite/binutils-all/x86-64/pr23494d.d    |  1 +
 9 files changed, 20 insertions(+)

diff --git a/binutils/ChangeLog b/binutils/ChangeLog
index 8dd2d78d53..b618044094 100644
--- a/binutils/ChangeLog
+++ b/binutils/ChangeLog
@@ -1,3 +1,15 @@
+2018-08-10  H.J. Lu  <hongjiu.lu@intel.com>
+
+	* testsuite/binutils-all/x86-64/pr23494a-x32.d: Skip nacl
+	targets.
+	* testsuite/binutils-all/x86-64/pr23494a.d: Likewise.
+	* testsuite/binutils-all/x86-64/pr23494b-x32.d: Likewise.
+	* testsuite/binutils-all/x86-64/pr23494b.d: Likewise.
+	* testsuite/binutils-all/x86-64/pr23494c-x32.d: Likewise.
+	* testsuite/binutils-all/x86-64/pr23494c.d: Likewise.
+	* testsuite/binutils-all/x86-64/pr23494d-x32.d: Likewise.
+	* testsuite/binutils-all/x86-64/pr23494d.d: Likewise.
+
 2018-08-08  H.J. Lu  <hongjiu.lu@intel.com>
 
 	PR binutils/23494
diff --git a/binutils/testsuite/binutils-all/x86-64/pr23494a-x32.d b/binutils/testsuite/binutils-all/x86-64/pr23494a-x32.d
index 6171e3c80c..67e3aab89e 100644
--- a/binutils/testsuite/binutils-all/x86-64/pr23494a-x32.d
+++ b/binutils/testsuite/binutils-all/x86-64/pr23494a-x32.d
@@ -3,6 +3,7 @@
 #as: --x32
 #objcopy: -O elf64-x86-64
 #readelf: -n
+#not-target: x86_64-*-nacl*
 
 Displaying notes found in: .note.gnu.property
   Owner                 Data size	Description
diff --git a/binutils/testsuite/binutils-all/x86-64/pr23494a.d b/binutils/testsuite/binutils-all/x86-64/pr23494a.d
index 5e8b0b61c7..06c193867e 100644
--- a/binutils/testsuite/binutils-all/x86-64/pr23494a.d
+++ b/binutils/testsuite/binutils-all/x86-64/pr23494a.d
@@ -3,6 +3,7 @@
 #as: --64 -defsym __64_bit__=1
 #objcopy: -O elf32-x86-64
 #readelf: -n
+#not-target: x86_64-*-nacl*
 
 Displaying notes found in: .note.gnu.property
   Owner                 Data size	Description
diff --git a/binutils/testsuite/binutils-all/x86-64/pr23494b-x32.d b/binutils/testsuite/binutils-all/x86-64/pr23494b-x32.d
index e0b351b51d..f923e2fad6 100644
--- a/binutils/testsuite/binutils-all/x86-64/pr23494b-x32.d
+++ b/binutils/testsuite/binutils-all/x86-64/pr23494b-x32.d
@@ -3,3 +3,4 @@
 #as: --x32
 #objcopy: -O elf64-x86-64 -R .note.gnu.property
 #readelf: -n
+#not-target: x86_64-*-nacl*
diff --git a/binutils/testsuite/binutils-all/x86-64/pr23494b.d b/binutils/testsuite/binutils-all/x86-64/pr23494b.d
index 69c5340710..4916be08ad 100644
--- a/binutils/testsuite/binutils-all/x86-64/pr23494b.d
+++ b/binutils/testsuite/binutils-all/x86-64/pr23494b.d
@@ -3,3 +3,4 @@
 #as: --64 -defsym __64_bit__=1
 #objcopy: -O elf32-x86-64 -R .note.gnu.property
 #readelf: -n
+#not-target: x86_64-*-nacl*
diff --git a/binutils/testsuite/binutils-all/x86-64/pr23494c-x32.d b/binutils/testsuite/binutils-all/x86-64/pr23494c-x32.d
index 3f213dcd91..c4a9414b41 100644
--- a/binutils/testsuite/binutils-all/x86-64/pr23494c-x32.d
+++ b/binutils/testsuite/binutils-all/x86-64/pr23494c-x32.d
@@ -3,6 +3,7 @@
 #as: --x32
 #objcopy: -O elf64-x86-64
 #readelf: -n
+#not-target: x86_64-*-nacl*
 
 Displaying notes found in: .note.gnu.property
   Owner                 Data size	Description
diff --git a/binutils/testsuite/binutils-all/x86-64/pr23494c.d b/binutils/testsuite/binutils-all/x86-64/pr23494c.d
index 62500a8382..545777a2aa 100644
--- a/binutils/testsuite/binutils-all/x86-64/pr23494c.d
+++ b/binutils/testsuite/binutils-all/x86-64/pr23494c.d
@@ -3,6 +3,7 @@
 #as: --64 -defsym __64_bit__=1
 #objcopy: -O elf32-x86-64
 #readelf: -n
+#not-target: x86_64-*-nacl*
 
 Displaying notes found in: .note.gnu.property
   Owner                 Data size	Description
diff --git a/binutils/testsuite/binutils-all/x86-64/pr23494d-x32.d b/binutils/testsuite/binutils-all/x86-64/pr23494d-x32.d
index 106e6c05cb..264c9d93cd 100644
--- a/binutils/testsuite/binutils-all/x86-64/pr23494d-x32.d
+++ b/binutils/testsuite/binutils-all/x86-64/pr23494d-x32.d
@@ -3,6 +3,7 @@
 #as: --x32
 #objcopy: -O elf64-x86-64 --decompress-debug-sections
 #readelf: -n
+#not-target: x86_64-*-nacl*
 
 Displaying notes found in: .note.gnu.property
   Owner                 Data size	Description
diff --git a/binutils/testsuite/binutils-all/x86-64/pr23494d.d b/binutils/testsuite/binutils-all/x86-64/pr23494d.d
index bcbcbc5c1f..3237eca54e 100644
--- a/binutils/testsuite/binutils-all/x86-64/pr23494d.d
+++ b/binutils/testsuite/binutils-all/x86-64/pr23494d.d
@@ -3,6 +3,7 @@
 #as: --64 -defsym __64_bit__=1
 #objcopy: -O elf32-x86-64 --decompress-debug-sections
 #readelf: -n
+#not-target: x86_64-*-nacl*
 
 Displaying notes found in: .note.gnu.property
   Owner                 Data size	Description
-- 
2.17.1

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]