This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
RE: [PATCH 3/5] [ARC] Update merging attributes.
- From: Claudiu Zissulescu <claziss at synopsys dot com>
- To: Nick Clifton <nickc at redhat dot com>, Claudiu Zissulescu <claziss at gmail dot com>, "binutils at sourceware dot org" <binutils at sourceware dot org>
- Cc: "Francois dot Bedard at synopsys dot com" <Francois dot Bedard at synopsys dot com>
- Date: Thu, 2 Aug 2018 13:02:19 +0000
- Subject: RE: [PATCH 3/5] [ARC] Update merging attributes.
- References: <20180724142641.2678-1-claziss@gmail.com> <20180724142641.2678-3-claziss@gmail.com> <4cf97e14-a0ec-4e4a-ec96-48a693792347@redhat.com>
Hi Nick,
The name can be arbitrary. This attribute is used by various customers to pretty print their specific CPU. What really counts is the CPU_base, and CPU_variation.
When the CPU_name conflicts, then we should choose one of them.
Please let me know if you have extra questions,
Claudiu
> -----Original Message-----
> From: Nick Clifton [mailto:nickc@redhat.com]
> Sent: Tuesday, July 31, 2018 6:05 PM
> To: Claudiu Zissulescu <claziss@gmail.com>; binutils@sourceware.org
> Cc: Francois.Bedard@synopsys.com; Claudiu Zissulescu
> <claziss@synopsys.com>
> Subject: Re: [PATCH 3/5] [ARC] Update merging attributes.
>
> Hi Claudiu,
>
> > bfd/
> > 2017-09-19 Claudiu Zissulescu <claziss@synopsys.com>
> >
> > * elf32-arc.c (arc_elf_merge_attributes): Fix merge attributes.
> >
> > ld/
> > 2017-09-19 Claudiu Zissulescu <claziss@synopsys.com>
> >
> > * testsuite/ld-arc/attr-merge-6.d: New file.
> > * testsuite/ld-arc/attr-merge-6a.s: Likewise.
> > * testsuite/ld-arc/attr-merge-6b.s: Likewise.
> > * testsuite/ld-arc/attr-merge-6bis.d: Likewise.
>
>
> > case Tag_ARC_CPU_name:
> > + if (!out_attr[i].s && in_attr[i].s)
> > + out_attr[i].s = _bfd_elf_attr_strdup (obfd, in_attr[i].s);
> > break;
>
> What should happen if out_attr[i].s and in_attr[i].s are both defined, and
> different ?
>
> Cheers
> Nick