This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 3/6] x86: improve operand reversal


On Wed, Aug 1, 2018 at 11:49 PM, Jan Beulich <JBeulich@suse.com> wrote:
> In quite a few cases the .s suffix or {load} / {store} prefixes did not
> work as intended, or produced errors when they're supposed to be ignored
> when it is not possible to carry out the request.
>
> The change here re-purposes(?) the .s suffix to no longer mean "store"
> (if that's what 's' did stand for), since the forms used in the base
> templates are not consistently loads (and we unlikely want to change
> that). The pseudo prefixes will now fulfill what their names say, i.e.
> {load} now only ever produces a load form encoding (if available) while
> {store} only ever produces a store form one (again if available). This
> requires minimal test suite adjustments, while the majority of the
> changes there are simply additions.
>

I prefer not to change the behavior of the `.s' suffix, unless it is to fix
the wrong encoding.  I don't see the need for the 'swap' pseudo prefix.
If the programmer doesn't care load/store encoding, "swap" isn't really
useful.

-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]