This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 2/5] xtensa: move dynamic relocations sections consistency check
- From: "augustine dot sterling at gmail dot com" <augustine dot sterling at gmail dot com>
- To: Max Filippov <jcmvbkbc at gmail dot com>
- Cc: binutils at sourceware dot org, Eric Tsai <erictsai at cadence dot com>, linux-xtensa at linux-xtensa dot org
- Date: Mon, 23 Jul 2018 11:58:40 -0700
- Subject: Re: [PATCH 2/5] xtensa: move dynamic relocations sections consistency check
- References: <20180723181030.11632-1-jcmvbkbc@gmail.com> <20180723181030.11632-3-jcmvbkbc@gmail.com>
On Mon, Jul 23, 2018 at 11:10 AM, Max Filippov <jcmvbkbc@gmail.com> wrote:
> The function elf_xtensa_finish_dynamic_sections checks that sizes of
> sections .rela.dyn and .rela.plt match number of corresponding relocation
> records, but the check is only done when .rela.plt is non-empty, so, e.g.
> it is never run for the static PIE.
> Rearrange the test so that .rela.dyn and .rela.plt are checked always.
>
> bfd/
> 2018-07-23 Max Filippov <jcmvbkbc@gmail.com>
>
> * elf32-xtensa.c (elf_xtensa_finish_dynamic_sections): Move
> relocation sections consistency check to always check both
> .rela.dyn and .rela.plt when they exist. Rearrange variable
> definition and assignment places.
Approved.