This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 0/5] xtensa: fix for ld and testsuite improvements
- From: "augustine dot sterling at gmail dot com" <augustine dot sterling at gmail dot com>
- To: Max Filippov <jcmvbkbc at gmail dot com>
- Cc: binutils at sourceware dot org, Eric Tsai <erictsai at cadence dot com>, linux-xtensa at linux-xtensa dot org
- Date: Mon, 23 Jul 2018 11:46:07 -0700
- Subject: Re: [PATCH 0/5] xtensa: fix for ld and testsuite improvements
- References: <20180723181030.11632-1-jcmvbkbc@gmail.com>
On Mon, Jul 23, 2018 at 11:10 AM, Max Filippov <jcmvbkbc@gmail.com> wrote:
> Hello,
>
> this series fixes a bug in relaxation of references to undefined weak
> dynamic symbols in shared objects on xtensa, rearranges ld-xtensa
> testsuite and adds new tests for relaxation in dynamic objects.
>
This series is acceptable. I'll reply to the individual patches also.
> Max Filippov (5):
> xtensa: fix relaxation of undefined weak references in shared objects
> xtensa: move dynamic relocations sections consistency check
> xtensa: ld: rename xtensa.exp to xtensa-linux.exp
> xtensa: ld: add tests for static linkage relaxation
> xtensa: ld: convert tests to run_dump_test
>
> bfd/elf32-xtensa.c | 25 ++---
> ld/testsuite/ld-xtensa/coalesce.d | 7 ++
> ld/testsuite/ld-xtensa/coalesce.exp | 99 ------------------
> ld/testsuite/ld-xtensa/diff_overflow.d | 6 ++
> ld/testsuite/ld-xtensa/diff_overflow.exp | 45 --------
> ld/testsuite/ld-xtensa/lcall.d | 10 ++
> ld/testsuite/ld-xtensa/lcall.exp | 113 ---------------------
> ld/testsuite/ld-xtensa/relax-static-defs.s | 33 ++++++
> ld/testsuite/ld-xtensa/relax-static-local-pie.d | 17 ++++
> ld/testsuite/ld-xtensa/relax-static-local-shared.d | 17 ++++
> ld/testsuite/ld-xtensa/relax-static-local.s | 19 ++++
> ld/testsuite/ld-xtensa/relax-static-pie.d | 13 +++
> ld/testsuite/ld-xtensa/relax-static-shared.d | 15 +++
> ld/testsuite/ld-xtensa/relax-static.s | 9 ++
> .../ld-xtensa/relax-undef-weak-local-pie.d | 6 ++
> .../ld-xtensa/relax-undef-weak-local-shared.d | 6 ++
> ld/testsuite/ld-xtensa/relax-undef-weak-local.s | 31 ++++++
> ld/testsuite/ld-xtensa/relax-undef-weak-pie.d | 6 ++
> ld/testsuite/ld-xtensa/relax-undef-weak-shared.d | 14 +++
> ld/testsuite/ld-xtensa/relax-undef-weak.s | 12 +++
> ld/testsuite/ld-xtensa/xtensa-linux.exp | 56 ++++++++++
> ld/testsuite/ld-xtensa/xtensa.exp | 42 +++-----
> 22 files changed, 302 insertions(+), 299 deletions(-)
> create mode 100644 ld/testsuite/ld-xtensa/coalesce.d
> delete mode 100644 ld/testsuite/ld-xtensa/coalesce.exp
> create mode 100644 ld/testsuite/ld-xtensa/diff_overflow.d
> delete mode 100644 ld/testsuite/ld-xtensa/diff_overflow.exp
> create mode 100644 ld/testsuite/ld-xtensa/lcall.d
> delete mode 100644 ld/testsuite/ld-xtensa/lcall.exp
> create mode 100644 ld/testsuite/ld-xtensa/relax-static-defs.s
> create mode 100644 ld/testsuite/ld-xtensa/relax-static-local-pie.d
> create mode 100644 ld/testsuite/ld-xtensa/relax-static-local-shared.d
> create mode 100644 ld/testsuite/ld-xtensa/relax-static-local.s
> create mode 100644 ld/testsuite/ld-xtensa/relax-static-pie.d
> create mode 100644 ld/testsuite/ld-xtensa/relax-static-shared.d
> create mode 100644 ld/testsuite/ld-xtensa/relax-static.s
> create mode 100644 ld/testsuite/ld-xtensa/relax-undef-weak-local-pie.d
> create mode 100644 ld/testsuite/ld-xtensa/relax-undef-weak-local-shared.d
> create mode 100644 ld/testsuite/ld-xtensa/relax-undef-weak-local.s
> create mode 100644 ld/testsuite/ld-xtensa/relax-undef-weak-pie.d
> create mode 100644 ld/testsuite/ld-xtensa/relax-undef-weak-shared.d
> create mode 100644 ld/testsuite/ld-xtensa/relax-undef-weak.s
> create mode 100644 ld/testsuite/ld-xtensa/xtensa-linux.exp
>
> --
> 2.11.0
>