This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
PowerPC64 fails reloc-discard test
- From: Alan Modra <amodra at gmail dot com>
- To: binutils at sourceware dot org
- Date: Mon, 23 Jul 2018 13:05:56 +0930
- Subject: PowerPC64 fails reloc-discard test
PowerPC64 fails here due to emitting a warning about discarded dynamic
relocations. That's a good thing, since accidentally discarding
dynamic relocations will likely result in a non-working binary.
* testsuite/ld-elf/reloc-discard-warn.d: New.
* testsuite/ld-elf/reloc-discard.d: Skip test on PowerPC64.
diff --git a/ld/testsuite/ld-elf/reloc-discard-warn.d b/ld/testsuite/ld-elf/reloc-discard-warn.d
new file mode 100644
index 0000000000..492abfa275
--- /dev/null
+++ b/ld/testsuite/ld-elf/reloc-discard-warn.d
@@ -0,0 +1,10 @@
+#name: Discarded dynamic relocation section
+#ld: -shared -T reloc-discard.ld
+#readelf: -r --use-dynamic
+#target: [check_shared_lib_support]
+#noskip: powerpc64*-*-*
+#source: reloc-discard.s
+#warning: .*discarding dynamic section.*
+# More targets should be using this variant of reloc-discard.d.
+
+There are no dynamic relocations in this file\.
diff --git a/ld/testsuite/ld-elf/reloc-discard.d b/ld/testsuite/ld-elf/reloc-discard.d
index b8aad88649..dd2c99b657 100644
--- a/ld/testsuite/ld-elf/reloc-discard.d
+++ b/ld/testsuite/ld-elf/reloc-discard.d
@@ -2,9 +2,12 @@
#ld: -shared -T reloc-discard.ld
#readelf: -r --use-dynamic
#target: [check_shared_lib_support]
+#skip: powerpc64*-*-*
#source: reloc-discard.s
#xfail: nds32*-*-* tic6x-*-*
# Need to figure out how to pass `-fpic' for NDS32 or `-mpic -mpid=near'
# for TI C6X targets to GAS for this test.
+# PowerPC64 warns when discarding dynamic relocs, which is generally
+# a good thing. See reloc-discard-warn.d test variant.
There are no dynamic relocations in this file\.
--
Alan Modra
Australia Development Lab, IBM