This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH + test RFA] MIPS/LD: Fix crashing with a discarded dynamic relocation section
- From: Nick Clifton <nickc at redhat dot com>
- To: "Maciej W. Rozycki" <macro at mips dot com>, Alan Modra <amodra at gmail dot com>
- Cc: binutils at sourceware dot org
- Date: Fri, 20 Jul 2018 11:22:57 +0100
- Subject: Re: [PATCH + test RFA] MIPS/LD: Fix crashing with a discarded dynamic relocation section
- References: <alpine.DEB.2.00.1807192156310.30992@tp.orcam.me.uk>
Hi Maciej,
> Most fail though, having produced rubbish in the dynamic segment just as
> MIPS would had it not crashed in `_bfd_mips_elf_finish_dynamic_sections'.
> I'm leaving it up to the respective maintainers to address; the piece I
> added in `_bfd_mips_elf_size_dynamic_sections' can serve as an obvious
> example. The only winners are `bfin-*-*' and `score-*-*'; they pass.
>
> One problem with a generic ELF `run_dump_test' case is that they are run
> in bulk with a glob matcher, precluding target-specific flag passing. As
> a result the test fails for `nds32*-*-*' and `tic6x-*-*' targets without
> actually checking whether they set dynamic contents right. I have XFAILed
> them for the time being, but a solution has to be eventually found.
>
> OK for the test part then?
Approved. Better to have a testcase that fails than a problem that no-one knows about...
Cheers
Nick