This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH/MIPS] Split Loongson MultiMedia extensions Instructions (MMI) from loongson2f/3a


Hi Paul,

 Thanks for the update and the follow-up.  When resubmitting please 
indicate patch revisions in the subject, e.g. [PATCH v2], [PATCH v3], etc. 
so it is clear which one is the most recent.

> >  Also I don't see any earlier changes from you in binutils and this change
> > is substantial enough to require a copyright arrangement with FSF before
> > it can be accepted.  Do you have one in place?
> 
> I have been signed binutils copyright assignment with FSF, but no
> write access yet.

 Good, I'll commit your change on your behalf then.

> >  Do you intend this text to become the commit description in the
> > repository?  If so, then please reformat it as a proper paragraph,
> > observing the 74-column limit and placing two spaces after full stops.
> 
> No, that just explain why use mmi.

 Please provide a change description then.  As the submitter you are in 
the best position to write one.  I may come up with something myself, but 
this will take my time, delaying processing, and whatever I end up with 
may not be accurate.

 In that description please explain why you are making your change and, if 
necessary (use your own judgement, e.g. explain any code you think the 
reviewer may question), what were the key design and implementation 
decisions.  This is a general guidance, applying to any changes submitted.

  Maciej


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]