This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] x86: adjust monitor/mwait templates
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Jan Beulich <JBeulich at suse dot com>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Tue, 10 Jul 2018 07:02:20 -0700
- Subject: Re: [PATCH] x86: adjust monitor/mwait templates
- References: <5B44B60702000078001D2AF4@prv1-mh.provo.novell.com>
On Tue, Jul 10, 2018 at 6:35 AM, Jan Beulich <JBeulich@suse.com> wrote:
> Architecturally, MONITOR's and MONITORX'es memory operand is a 16- or
> 32-bit register outside of 64-bit mode, and a 64- or 32-bit register
> inside 64-bit mode. The other register operands, including all of them
> for MWAIT and MWAITX, are uniformly 32-bit, irrespective of mode. Retain
> the original 64-bit MONITOR{,X} templates for compatibility only, and
> fold the MWAIT{,X} ones.
>
> opcodes/
> 2018-07-10 Jan Beulich <jbeulich@suse.com>
>
> * i386-gen.c (monitor, monitorx): Add 64-bit template requiring
> 32-bit registers as operands 2 and 3. Improve comments.
> (mwait, mwaitx): Fold templates. Improve comments.
> OPERAND_TYPE_INOUTPORTREG.
> * i386-tbl.h: Re-generate.
>
OK.
Thanks.
--
H.J.