This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
nds32 testcase fix
- From: Jeff Law <law at redhat dot com>
- To: Binutils <binutils at sourceware dot org>
- Date: Mon, 9 Jul 2018 10:36:50 -0600
- Subject: nds32 testcase fix
My tester uses GCC's contrib/compare-tests to compare test runs of the
various tools it builds.
One of the things that comparison tool does not like are tests with the
same name, *particularly* if some pass and some fail. For example:
law@gcc76:~/jenkins/workspace/nds32be-elf$ grep nds32\ load-store */gas.sum
old-testresults/gas.sum:PASS: nds32 load-store immediate instructions
old-testresults/gas.sum:PASS: nds32 load-store instructions
old-testresults/gas.sum:FAIL: nds32 load-store instructions
Note we have on test called "nds32 load-store instructions" that passes
and another that fails within the same run. This causes the comparison
tool to think that the results of the test are changing from one run to
the next.
In this specific case, one of the two tests is just mis-named.
nds32/ji-jr.d tests jump instructions, but its name tag is load-store
instructions.
The fix is pretty obvious, adjust the name tag on the ji-jr test.
Installed on the trunk.
Jeff
commit 2af4d0d938d76e96ccb862a23d05862154262de9
Author: Jeff Law <law@redhat.com>
Date: Mon Jul 9 10:35:12 2018 -0600
* testsuite/nds32/ji-jr.d: Fix name tag.
diff --git a/gas/ChangeLog b/gas/ChangeLog
index 70357b9d75..d49fc1151a 100644
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,3 +1,7 @@
+2018-07-09 Jeff Law <law@redhat.com>
+
+ * testsuite/nds32/ji-jr.d: Fix name tag.
+
2018-07-06 Tamar Christina <tamar.christina@arm.com>
PR binutils/23369
diff --git a/gas/testsuite/gas/nds32/ji-jr.d b/gas/testsuite/gas/nds32/ji-jr.d
index ac79218654..120c8c1b13 100644
--- a/gas/testsuite/gas/nds32/ji-jr.d
+++ b/gas/testsuite/gas/nds32/ji-jr.d
@@ -1,5 +1,5 @@
#objdump: -dr --prefix-addresses
-#name: nds32 load-store instructions
+#name: nds32 ji-jr instructions
#as:
# Test ls instructions