This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Does anyone want to delay creating the 2.31 release this weekend (July 7/8) ?


On Fri, Jul 06, 2018 at 11:42:16PM +0930, Alan Modra wrote:
> On Fri, Jul 06, 2018 at 01:50:33PM +0100, Nick Clifton wrote:
> > Hi Guys,
> > 
> >   Does anyone want me to delay creating the 2.31 release this weekend ?
> 
> I'm seeing regressions that appear to be due to the config.sub/guess
> update, so yes, I think the 2.31 release should be delayed until we
> sort that out.
> 
> xgate-elf and m68hc12-elf both show
> FAIL: strip on STB_GNU_UNIQUE
> and some other testsuite changes at git commit f4b933ddc03 and later.
> 
> I haven't tracked down why this is happening, and hadn't noticed it

The extra fails are nothing to worry about.

With config.sub now properly returning m68hc12-unknown-elf rather than
m68hc12-unknown-none, more ELF tests run.  This patch enables
STB_GNU_UNIQUE processing fixing some testsuite failures that probably
no m68hc12 user cares about, and removes some XPASSes.

bfd/
	* elf32-m68hc1x.c (elf32_m68hc11_post_process_headers): Call
	_bfd_elf_post_process_headers.
ld/
	* testsuite/ld-discard/extern.d: Remove m68hc12 xfail.
	* testsuite/ld-discard/start.d: Likewise.
	* testsuite/ld-discard/static.d: Likewise.

diff --git a/bfd/elf32-m68hc1x.c b/bfd/elf32-m68hc1x.c
index 35152ee1c7..d411bd076d 100644
--- a/bfd/elf32-m68hc1x.c
+++ b/bfd/elf32-m68hc1x.c
@@ -1456,6 +1456,8 @@ elf32_m68hc11_post_process_headers (bfd *abfd, struct bfd_link_info *link_info)
   struct m68hc11_scan_param param;
   struct m68hc11_elf_link_hash_table *htab;
 
+  _bfd_elf_post_process_headers (abfd, link_info);
+
   if (link_info == NULL)
     return;
 
diff --git a/ld/testsuite/ld-discard/extern.d b/ld/testsuite/ld-discard/extern.d
index 50112e45e7..a8d91fb872 100644
--- a/ld/testsuite/ld-discard/extern.d
+++ b/ld/testsuite/ld-discard/extern.d
@@ -3,7 +3,6 @@
 #error: .*data.* referenced in section `\.text' of tmpdir/extern.o: defined in discarded section `\.data\.exit' of tmpdir/extern.o
 #objdump: -p
 #xfail: d30v-*-* dlx-*-* pj*-*-*
-#xfail: m68hc12-*-* m6812-*-*
 #pass
 # The expected warning used to start with "`data' referenced..." but
 # this has two problems: 1) It does not include the name of the linker
diff --git a/ld/testsuite/ld-discard/start.d b/ld/testsuite/ld-discard/start.d
index e8ce59d62c..fcb4e8fee0 100644
--- a/ld/testsuite/ld-discard/start.d
+++ b/ld/testsuite/ld-discard/start.d
@@ -4,5 +4,4 @@
 #error: `data' referenced in section `\.text' of tmpdir/start.o: defined in discarded section `\.data\.exit' of tmpdir/exit.o
 #objdump: -p
 #xfail: d30v-*-* dlx-*-* pj*-*-*
-#xfail: m68hc12-*-* m6812-*-*
 #pass
diff --git a/ld/testsuite/ld-discard/static.d b/ld/testsuite/ld-discard/static.d
index ebdbda840e..c80fcde087 100644
--- a/ld/testsuite/ld-discard/static.d
+++ b/ld/testsuite/ld-discard/static.d
@@ -3,5 +3,4 @@
 #error: `(\.data\.exit|data)' referenced in section `\.text' of tmpdir/static.o: defined in discarded section `\.data\.exit' of tmpdir/static.o
 #objdump: -p
 #xfail: d30v-*-* dlx-*-* pj*-*-*
-#xfail: m68hc12-*-* m6812-*-* 
 #pass


-- 
Alan Modra
Australia Development Lab, IBM


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]