This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
RE: [PATCH][AArch64][binutils] Fix SBO bit in disassembly mask for ldrah.
- From: Tamar Christina <Tamar dot Christina at arm dot com>
- To: Tamar Christina <Tamar dot Christina at arm dot com>, "binutils at sourceware dot org" <binutils at sourceware dot org>
- Cc: nd <nd at arm dot com>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, Marcus Shawcroft <Marcus dot Shawcroft at arm dot com>
- Date: Thu, 5 Jul 2018 11:05:51 +0000
- Subject: RE: [PATCH][AArch64][binutils] Fix SBO bit in disassembly mask for ldrah.
- References: <20180629132903.GA29994@arm.com>
Ping 😊
> -----Original Message-----
> From: binutils-owner@sourceware.org <binutils-owner@sourceware.org>
> On Behalf Of Tamar Christina
> Sent: Friday, June 29, 2018 14:29
> To: binutils@sourceware.org
> Cc: nd <nd@arm.com>; Richard Earnshaw <Richard.Earnshaw@arm.com>;
> Marcus Shawcroft <Marcus.Shawcroft@arm.com>
> Subject: [PATCH][AArch64][binutils] Fix SBO bit in disassembly mask for ldrah.
>
> Hi All,
>
> The disassembly mask for ldarh incorrectly didn't mask out bit 20 which is part
> of the SBO part of the instruction and shouldn't be considered input.
>
> This fixes the wrong bit fixing the disassembly of instructions to ldarh and
> makes the behavior consistent.
>
> Build on native hardware and regtested on
> aarch64-none-elf, aarch64-none-elf (32 bit host),
> aarch64-none-linux-gnu, aarch64_be-none-linux-gnu
>
> Cross-compiled and regtested on
> aarch64-none-linux-gnu, aarch64_be-none-linux-gnu
>
> and no issues.
>
> Ok for master? and for backport to binutils-2.31?
>
> Thanks,
> Tamar
>
> opcodes/
> 2018-06-29 Tamar Christina <tamar.christina@arm.com>
>
> PR binutils/23242
> * aarch64-tbl.h (ldarh): Fix disassembly mask.
>
> --