This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] ld: Set non_ir_ref_regular for --undefined SYMBOL

From: "H.J. Lu" <hjl dot tools at gmail dot com>
To: Alan Modra <amodra at gmail dot com>, Nick Clifton <nickc at redhat dot com>
Cc: Binutils <binutils at sourceware dot org>
Date: Wed, 4 Jul 2018 06:38:04 -0700
Subject: Re: [PATCH] ld: Set non_ir_ref_regular for --undefined SYMBOL
References: <20180702224314.645-1-hjl.tools@gmail.com> <20180704121916.GZ3404@bubble.grove.modra.org>

On Wed, Jul 4, 2018 at 5:19 AM, Alan Modra <amodra@gmail.com> wrote:
> On Mon, Jul 02, 2018 at 03:43:14PM -0700, H.J. Lu wrote:
>> Set non_ir_ref_regular to TRUE for symbols forced into the output file
>> so that they won't be removed by garbage collection with LTO.
>>
>>       PR ld/23309
>>       * ldlang.c (insert_undefined): Set non_ir_ref_regular to TRUE.
>>       * plugin.c (is_visible_from_outside): Don't scan entry_symbol.
>>       * testsuite/ld-plugin/pr23309.c: New file.
>>       * testsuite/ld-plugin/pr23309.d: Likewise.
>
> Looks good to me.
>

Checked in master.  OK for 2.31 branch?


-- 
H.J.

References:
- [PATCH] ld: Set non_ir_ref_regular for --undefined SYMBOL
  - From: H.J. Lu
- Re: [PATCH] ld: Set non_ir_ref_regular for --undefined SYMBOL
  - From: Alan Modra

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]