Re: [PATCH] AROS: update supported targets for the AROS operating system.

[Nick Clifton <nickc at redhat dot com>]

Hi Kalamatee,

Sorry for the delay in reviewing this patch.

Unfortunately there are a few problems with it:

>> --- a/bfd/config.bfd
>> +++ b/bfd/config.bfd

>> -  m68*-*-elf* | m68*-*-sysv4* | m68*-*-rtems* | m68*-*-uclinux*)
>> +  m68*-*-elf* | m68*-*-sysv4* | m68*-*-rtems* | m68*-*-uclinux* |
>> m68*-*-aros)

The m68 target has now been generalised to a single entry, so this frag is not needed.


>> +    targ_selvecs="powerpc_elf64_le_vec powerpc_elf32_vec
>> powerpc_elf32_le_vec"

Your mailer appears to be word-wrapping the patch, which makes it impossible
to apply.  If possible please could you turn this off, or else attach the
patch as a compressed file.



>> +++ b/binutils/configure

The binutils/configure, intl/configure and ld/Makefile.in files are all
automatically generated.  So please could you provide a patch against
the originating files instead.  (binutils/configure.ac, intl/configure.ac
and ld/Makefile.am repsectively).


>> --- a/binutils/sysdep.h
>> +++ b/binutils/sysdep.h
>> @@ -24,6 +24,7 @@
>>  #include "ansidecl.h"
>>  #include <stdio.h>
>>  #include <sys/types.h>
>> +#include <sys/stat.h>
>>
>>  #include "bfdver.h"

This patch is wrong.  The <sys/stat.h> header file is already included
further on in the sysdep.h file.



>> --- a/config.guess
>> +++ b/config.guess
>> @@ -333,6 +333,9 @@
>>      *:[Mm]orph[Oo][Ss]:*:*)
>>   echo ${UNAME_MACHINE}-unknown-morphos
>>   exit ;;
>> +    *:AROS:*:*)
>> + echo ${UNAME_MACHINE}-unknown-aros
>> + exit ;;
>>      *:OS/390:*:*)
>>   echo i370-ibm-openedition
>>   exit ;;

Whilst useful for testing purposes, this patch cannot be reviewed, approved
or committed by us.  The top level config.guess file is part of the GNU
config project (config-patches@gnu.org).


If you can provide an updated patch, made against the current sources, I
will be happy to review it again.

Cheers
  Nick