This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] xtensa: use property tables for correct disassembly
- From: "augustine dot sterling at gmail dot com" <augustine dot sterling at gmail dot com>
- To: Max Filippov <jcmvbkbc at gmail dot com>
- Cc: binutils at sourceware dot org, Eric Tsai <erictsai at cadence dot com>, linux-xtensa at linux-xtensa dot org
- Date: Mon, 4 Jun 2018 10:20:13 -0700
- Subject: Re: [PATCH] xtensa: use property tables for correct disassembly
- References: <20180530183023.8447-1-jcmvbkbc@gmail.com>
On Wed, May 30, 2018 at 11:30 AM, Max Filippov <jcmvbkbc@gmail.com> wrote:
> 2018-05-30 Max Filippov <jcmvbkbc@gmail.com>
> bfd/
> * elf32-xtensa.c (xtensa_read_table_entries): Make global.
> (compute_fill_extra_space): Drop declaration. Rename function to
> xtensa_compute_fill_extra_space.
> (compute_ebb_actions, remove_dead_literal): Update references to
> compute_fill_extra_space.
>
> include/
> * elf/xtensa.h (xtensa_read_table_entries)
> (xtensa_compute_fill_extra_space): New declarations.
>
> opcodes/
> * xtensa-dis.c (bfd.h, elf/xtensa.h): New includes.
> (dis_private): Add new fields for property section tracking.
> (xtensa_coalesce_insn_tables, xtensa_find_table_entry)
> (xtensa_instruction_fits): New functions.
> (fetch_data): Bump minimal fetch size to 4.
> (print_insn_xtensa): Make struct dis_private static.
> Load and prepare property table on section change.
> Don't disassemble literals. Don't disassemble instructions that
> cross property table boundaries.
>
Approved. Thanks.