This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] ld: Hide symbols defined by HIDDEN/PROVIDE_HIDDEN

On Fri, May 18, 2018 at 8:39 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Fri, May 18, 2018 at 8:23 PM, Alan Modra <amodra@gmail.com> wrote:
>> On Fri, May 18, 2018 at 10:56:21AM -0700, H.J. Lu wrote:
>>> The updated patch to call elf_backend_hide_symbol instead of
>>> _bfd_elf_link_hash_hide_symbol.
>>
>> I see x86_64-linux and powerpc64le-linux segfaults with this patch.
>

Do you have a testcase?

>
>> I'm also unconvinced that we need bfd_link_hide_symbol.  We'll be
>> calling bfd_elf_record_link_assignment for any symbol defined by a
>> linker script.  Why can't bfd_elf_record_link_assignment be corrected
>> if it is doing something wrong?
>
> bfd_elf_record_link_assignment is called too late. I need this info
> when scanning relocation.
>
> --
> H.J.



-- 
H.J.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]