This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Use DIAG_IGNORE_NEEDS_COMMENT to silence -Wstringop-truncation


On Mon, May 07, 2018 at 06:43:15AM -0700, H.J. Lu wrote:
> GCC 8 warns about destination size with -Wstringop-truncation:
> 
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85643
> 
> Copy DIAG_PUSH_NEEDS_COMMENT, DIAG_POP_NEEDS_COMMENT and
> DIAG_IGNORE_NEEDS_COMMENT from glibc 2.27 to silence it.

I'm inclined to think we don't need this patch.  It certainly isn't
needed for binutils releases, as we don't enable -Werror by default for
releases.  The problem mostly affect developers using bleeding edge
toolchains, and I have every confidence that the gcc bug will be fixed
quickly.

Also, not all binutils users have glibc installed.  We can't depend on
a macro defined in glibc's /usr/include/features.h, __GNUC_PREREQ.

-- 
Alan Modra
Australia Development Lab, IBM


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]