This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/3] Enable Intel CLDEMOTE instructions.


On Mon, Apr 16, 2018 at 2:49 PM, Tsimbalist, Igor V
<igor.v.tsimbalist@intel.com> wrote:
>> -----Original Message-----
>> From: Jan Beulich [mailto:jbeulich@suse.com]
>> Sent: Sunday, April 15, 2018 3:30 PM
>> To: Tsimbalist, Igor V <igor.v.tsimbalist@intel.com>
>> Cc: Lu, Hongjiu <hongjiu.lu@intel.com>; binutils@sourceware.org
>> Subject: Re: [PATCH 2/3] Enable Intel CLDEMOTE instructions.
>>
>> >>> "Tsimbalist, Igor V" <igor.v.tsimbalist@intel.com> 04/13/18 2:13 PM
>> >>>
>> >opcode/
>> >* i386-dis.c (dis386_twobyte): Add cldemote.
>>
>> This is wrong: CLDEMOTE isn't all of 0F 1C, but only 0F 1C /0, and only with
>> none of 66, F3, or F2 prefixes. With that corrected, quite a bit of what you
>> drop
>> from the NOP testcases can and should also be left untouched.
>
> Yes, you are right. The updated patch is attached.
>

OK.

Thanks.

-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]