This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 1/3] Enable Intel WAITPKG instructions.
- From: "Jan Beulich" <JBeulich at suse dot com>
- To: "Igor V Tsimbalist" <igor dot v dot tsimbalist at intel dot com>
- Cc: "Hongjiu Lu" <hongjiu dot lu at intel dot com>, "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Mon, 09 Apr 2018 07:49:31 -0600
- Subject: Re: [PATCH 1/3] Enable Intel WAITPKG instructions.
- References: <D511F25789BA7F4EBA64C8A63891A002AFB067DE@IRSMSX102.ger.corp.intel.com>
>>> On 09.04.18 at 15:41, <igor.v.tsimbalist@intel.com> wrote:
> Intel has disclosed a set of new instructions for Tremont processor.
> The spec is
> https://software.intel.com/en-us/intel-architecture-instruction-set-extensions-pro
> gramming-reference
>
> This patch enables Intel WAITPKG instructions.
>
> gas/
> * config/tc-i386.c (cpu_arch): Add WAITPKG.
> (cpu_noarch): Likewise.
> * doc/c-i386.texi: Document WAITPKG.
> * i386/i386.exp: Run WAITPKG tests.
> * testsuite/gas/i386/waitpkg-intel.d: New test.
> * testsuite/gas/i386/waitpkg.d: Likewise.
> * testsuite/gas/i386/waitpkg.s: Likewise.
> * testsuite/gas/i386/x86-64-waitpkg-intel.d: Likewise.
> * testsuite/gas/i386/x86-64-waitpkg.d: Likewise.
> * testsuite/gas/i386/x86-64-waitpkg.s: Likewise.
>
> opcodes/
> * i386-dis.c (enum): Add PREFIX_MOD_0_0FAE_REG_6,
> PREFIX_MOD_1_0FAE_REG_6.
> * i386-dis-evex.h (prefix_table):
> New instructions (see prefixes above).
> * i386-gen.c (cpu_flag_init): Add WAITPKG.
> (cpu_flags): Likewise.
> * i386-opc.h (enum): Likewise.
> (i386_cpu_flags): Likewise.
> * i386-opc.tbl: Add umonitor, umwait, tpause.
I don't think IgnoreSize is necessary anywhere here. While there
are many bad examples, I think it would be helpful if we stopped
adding unnecessary attributes to new insns. Quite far down on
my list of things to change is an item to drop all unnecessary
attributes, such that the table isn't any larger (and more difficult
to read/inspect) than needed.
Jan