This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Make stringify.sed a dependency of ALL_EMULATION_SOURCES.

From: John Darrington <john at darrington dot wattle dot id dot au>
To: Alan Modra <amodra at gmail dot com>
Cc: John Darrington <john at darrington dot wattle dot id dot au>, binutils at sourceware dot org
Date: Sat, 24 Mar 2018 08:47:42 +0100
Subject: Re: [PATCH] Make stringify.sed a dependency of ALL_EMULATION_SOURCES.
References: <201803132003.w2DK3Jj7018307@jocasta.intra> <20180316002500.GF3812@bubble.grove.modra.org>

On Fri, Mar 16, 2018 at 10:55:00AM +1030, Alan Modra wrote:
     On Tue, Mar 13, 2018 at 08:37:41PM +0100, John Darrington wrote:
     > * ld/Makefile.am ld/Makefile.in: ALL_EMULATION_SOURCES add dependency stringify.sed.
     >   Otherwise out of source builds fail.
     
     For which target?  We ought to already have the dependency via
     GEN_DEPENDS.

Ahh thanks.  


Would it not be a good idea to change genscript.sh and/or elf32.em such that it exits with 
an error if stringify.sed does not exist?

Otherwise it happily creates a em*.c file, which in turn generates a linker which crashes 
when run.
     
J'

-- 
Avoid eavesdropping.  Send strong encrypted email.
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.

Attachment: signature.asc
Description: Digital signature

References:
- [PATCH] Make stringify.sed a dependency of ALL_EMULATION_SOURCES.
  - From: John Darrington
- Re: [PATCH] Make stringify.sed a dependency of ALL_EMULATION_SOURCES.
  - From: Alan Modra

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]