This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Commit: PR 22875: Stop strip corrupting unknown relocs
- From: Pedro Alves <palves at redhat dot com>
- To: Nick Clifton <nickc at redhat dot com>, Alan Modra <amodra at gmail dot com>
- Cc: binutils at sourceware dot org
- Date: Thu, 1 Mar 2018 11:28:59 +0000
- Subject: Re: Commit: PR 22875: Stop strip corrupting unknown relocs
- Authentication-results: sourceware.org; auth=none
- References: <87po4qwxjq.fsf@redhat.com> <20180227102711.GV3812@bubble.grove.modra.org> <1463375f-fb3b-7685-efd0-68e6388e1d95@redhat.com>
On 02/27/2018 12:15 PM, Nick Clifton wrote:
> Hi Alan,
>
>> Please use "%pB: unsupported relocation type %#x". A lot of work went
>> into reducing all the unsupported/invalid reloc message variants.
>
> Sorry - I forgot to go through and check all the messages.
>
> I am checking in this patch to fix up the ones that I missed.
It sounds like a few helper functions like:
void
bfd_error_unsupported_relocation (bfd *abfd, unsigned r_type)
{
_bfd_error_handler (_("%pB: unsupported relocation type: %#x"),
abfd, code);
}
would help make sure ports are consistent, now and going forward.
Thanks,
Pedro Alves