Re: [PATCH] x86: Add .nop directive to assembler

[John Darrington <john at darrington dot wattle dot id dot au>]

On Mon, Feb 26, 2018 at 12:08:18PM -0800, H.J. Lu wrote:
     On Mon, Feb 26, 2018 at 11:17 AM, John Darrington
     <john@darrington.wattle.id.au> wrote:
     > On Mon, Feb 26, 2018 at 11:03:12AM -0800, H.J. Lu wrote:
     >      On Mon, Feb 26, 2018 at 11:00 AM, John Darrington
     >      <john@darrington.wattle.id.au> wrote:
     >      > I haven't read every post in this thread, nor do I pretend to understand all the
     >      > issues.
     >      >
     >      > But it this change seems to have the effect that any instruction called "NOP"
     >      > in the .s file are completely ignored :(
     >      >
     >      > Many cpus have  a NOP instruction. It's often used in realtime systems to
     >      > implement short delays.
     >
     >      Which target have you tried?
     >
     >
     > hcs12z
     >
     
     I got
     
     [hjl@gnu-cfl-1 gas]$ cat x.s
     nop
     [hjl@gnu-cfl-1 gas]$ ./as-new -o x.o x.s -m68hcs12
     [hjl@gnu-cfl-1 gas]$ ../binutils/objdump -dw x.o
     
     x.o:     file format elf32-m68hc12
     
     
     Disassembly of section .text:
     
     00000000 <.text>:
        0: a7          nop
     [hjl@gnu-cfl-1 gas]$
     
     Am I missing something?
     
After applying commit 8f065d3b4a814b5a69b3f39700fea7034c79c492dd
the problem seems to have been fixed.

Thanks.


-- 
Avoid eavesdropping.  Send strong encrypted email.
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.

Attachment: signature.asc
Description: Digital signature