This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH][GAS][ARM] Fix AArch32 build attributes for Armv8.4-A.

Hi All,

The build attribute number for Armv8.4-A is currently incorrectly set to that of Armv8-M.
This patch fixes that by setting it as part of the Armv8-A family and adds a test for it.

Regtested on cross build:

 * arm-none-eabi
 * armeb-none-eabi

Bootstrapped and regtested on:

 * arm-none-eabi
 * arm-none-eabi (64 bit host)

and no issues.

Ok for master?

And also requesting permission to backport to binutils 2.30.

2018-02-15  Tamar Christina  <>

	* config/tc-arm.c (cpu_arch_ver): Renumber ARM_ARCH_V8_4A.
	* testsuite/gas/arm/attr-march-armv8_4-a.d: New.


diff --git a/gas/config/tc-arm.c b/gas/config/tc-arm.c
index 7a5c02b2bb872453c87b33308c1bda8819c7bafa..cac4ed9ab9712735bc8b3fb438add6267e2c0e51 100644
--- a/gas/config/tc-arm.c
+++ b/gas/config/tc-arm.c
@@ -26941,7 +26941,7 @@ static const cpu_arch_ver_table cpu_arch_ver[] =
     {16, ARM_ARCH_V8M_BASE},
     {17, ARM_ARCH_V8M_MAIN},
     {15, ARM_ARCH_V8R},
-    {16, ARM_ARCH_V8_4A},
+    {14, ARM_ARCH_V8_4A},
     {-1, ARM_ARCH_NONE}
diff --git a/gas/testsuite/gas/arm/attr-march-armv8_4-a.d b/gas/testsuite/gas/arm/attr-march-armv8_4-a.d
new file mode 100644
index 0000000000000000000000000000000000000000..af3e52b4bb953429b66e45aa8c6a63922526e99e
--- /dev/null
+++ b/gas/testsuite/gas/arm/attr-march-armv8_4-a.d
@@ -0,0 +1,17 @@
+# name: attributes for -march=armv8.4-a
+# source: blank.s
+# as: -march=armv8.4-a
+# readelf: -A
+# This test is only valid on EABI based ports.
+# target: *-*-*eabi* *-*-nacl*
+Attribute Section: aeabi
+File Attributes
+  Tag_CPU_name: "8.4-A"
+  Tag_CPU_arch: v8
+  Tag_CPU_arch_profile: Application
+  Tag_ARM_ISA_use: Yes
+  Tag_THUMB_ISA_use: Thumb-2
+  Tag_Advanced_SIMD_arch: NEON for ARMv8.1
+  Tag_MPextension_use: Allowed
+  Tag_Virtualization_use: TrustZone and Virtualization Extensions

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]