This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] gas: xtensa: fix trampoline placement
- From: Nick Clifton <nickc at redhat dot com>
- To: Max Filippov <jcmvbkbc at gmail dot com>, binutils at sourceware dot org
- Cc: Sterling Augustine <augustine dot sterling at gmail dot com>, linux-xtensa at linux-xtensa dot org
- Date: Mon, 12 Feb 2018 12:08:05 +0000
- Subject: Re: [PATCH] gas: xtensa: fix trampoline placement
- Authentication-results: sourceware.org; auth=none
- References: <1518394481-6214-1-git-send-email-jcmvbkbc@gmail.com>
Hi Max,
Would you mind updating your recent commits please ?
> + /* Don't choose trampoline that contains the source. */
> + if (source >= trampoline_frag->fr_address &&
> + source <= trampoline_frag->fr_address + trampoline_frag->fr_fix)
> + continue;
The GNU Coding standard requires that boolean conditional
operators should be at the start of a line, not the end:
https://www.gnu.org/prep/standards/html_node/Formatting.html#Formatting
So the above fragment, for example, should be:
/* Don't choose trampoline that contains the source. */
if (source >= trampoline_frag->fr_address
&& source <= trampoline_frag->fr_address + trampoline_frag->fr_fix)
continue;
Thanks.
Cheers
Nick