This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Update ld-elf/group1.d for Solaris


On Thu, Jan 18, 2018 at 4:12 PM, Alan Modra <amodra@gmail.com> wrote:
> On Thu, Jan 18, 2018 at 10:42:01AM -0800, H.J. Lu wrote:
>>       * testsuite/ld-elf/group1.d: Append "#...".
>
> OK.  It does weaken the test a little since we're no longer checking
> that "bar" is missing, but I think we can live with that.  If "foo" is
> weak that indicates the symbols from the discarded comdat group are
> being handled correctly.

Let's not weaken the test.  I am checking in this patch to xfail Solaris
instead.

Thanks.

-- 
H.J.
From 4448c7b16294001f001c405f68a2dfa8e7c6aa0a Mon Sep 17 00:00:00 2001
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Thu, 18 Jan 2018 10:07:50 -0800
Subject: [PATCH] Also xfail ld-elf/group1.d for Solaris

Also xfail ld-elf/group1.d for Solaris since _GLOBAL_OFFSET_TABLE_ is
always generated for Solaris as a global symbol after

.*: 0+1000 +0 +(NOTYPE|OBJECT) +WEAK +DEFAULT +. foo

instead of appending "#..." which will weaken the test.

	* testsuite/ld-elf/group1.d: Also xfail Solaris.
---
 ld/testsuite/ld-elf/group1.d | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ld/testsuite/ld-elf/group1.d b/ld/testsuite/ld-elf/group1.d
index e80d33827f..e355cd8718 100644
--- a/ld/testsuite/ld-elf/group1.d
+++ b/ld/testsuite/ld-elf/group1.d
@@ -2,7 +2,7 @@
 #source: group1b.s
 #ld: -T group.ld
 #readelf: -s
-#xfail: d30v-*-* dlx-*-* i960-*-* pj*-*-*
+#xfail: d30v-*-* dlx-*-* i960-*-* pj*-*-* *-*-solaris*
 # generic linker targets don't comply with all symbol merging rules
 
 Symbol table '.symtab' contains .* entries:
-- 
2.14.3


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]