This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[gold commit] PR 22694: Fix -fuse-ld option to accept string argument
- From: Cary Coutant <ccoutant at gmail dot com>
- To: Binutils <binutils at sourceware dot org>, Nick Clifton <nickc at redhat dot com>
- Date: Mon, 15 Jan 2018 10:12:24 -0800
- Subject: [gold commit] PR 22694: Fix -fuse-ld option to accept string argument
- Authentication-results: sourceware.org; auth=none
PR 22042 complained that garbage text was being printed in the help
for the -fuse-ld option; this was caused by passing an empty string
to the gettext() function, which sometimes returns garbage when passed
an empty string. The quick fix was to replace "" with NULL as the helparg,
but that changed the parsing of the option, as gold uses the helparg to
determine whether an option takes an argument. This patch adds a
non-empty helparg string to fix both problems.
Nick, this PR is a 2.30 regression. Is it OK to backport this to the
2.30 branch? (Sorry, I should have done this last week, but it slipped
my mind.)
-cary
gold/
PR gold/22694
* options.h (-fuse-ld): Add correct helparg.