This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[PATCH] [GAS] Remove build warnings for a.out targets
- From: gnikl at users dot sourceforge dot net
- To: binutils at sourceware dot org
- Date: Thu, 11 Jan 2018 20:29:30 +0100
- Subject: [PATCH] [GAS] Remove build warnings for a.out targets
- Authentication-results: sourceware.org; auth=none
Hello,
Occasionally I build an out-of-tree a.out target (m68k-amigaos). After
a system upgrade which included a newer compiler (clang 4) the build
produces warnings like this:
warning: macro expansion producing 'defined' has undefined behavior
[-Wexpansion-to-defined]
This is caused by the macro gas/config/aout_gnu.h:USE_EXTENDED_RELOC.
Since it is in a header file, the warning triggers for several files.
I am unsure what solution is preferable, thus I am suggesting two
patches:
a) keep the offending macro but define it explicitly to 0 and 1
b) replace the macro usage with its value where it is used.
Either patch removes the warning for clang. I did not check with a
recent GCC.
Regards,
Gunther Nikl
---
a)
2018-01-12 Gunther Nikl <gnikl@users.sourceforge.net>
* gas/config/aout_gnu.h (USE_EXTENDED_RELOC): Explicitly
define to 0 and 1. Remove a dangling reference to "AMD 29000"
in a comment.
--- a/gas/config/aout_gnu.h
+++ b/gas/config/aout_gnu.h
@@ -32,8 +32,6 @@
*/
-#define USE_EXTENDED_RELOC defined(TC_SPARC)
-
#if defined(TC_SPARC)
enum reloc_type
{
@@ -61,7 +59,9 @@ enum reloc_type
NO_RELOC
};
-
+#define USE_EXTENDED_RELOC 1
+#else
+#define USE_EXTENDED_RELOC 0
#endif /* TC_SPARC */
#define __GNU_EXEC_MACROS__
@@ -303,7 +303,7 @@ struct nlist
/* The following enum and struct were borrowed from SunOS's
/usr/include/sun4/a.out.h and extended to handle
- other machines. It is currently used on SPARC and AMD 29000.
+ other machines. It is currently used on SPARC.
reloc_ext_bytes is how it looks on disk. reloc_info_extended is
how we might process it on a native host. */
---
b)
2018-01-12 Gunther Nikl <gnikl@users.sourceforge.net>
* gas/config/aout_gnu.h (USE_EXTENDED_RELOC): Replace macro
usage with its value. Remove a dangling reference to "AMD
29000" in a comment.
--- a/gas/config/aout_gnu.h
+++ b/gas/config/aout_gnu.h
@@ -32,8 +32,6 @@
*/
-#define USE_EXTENDED_RELOC defined(TC_SPARC)
-
#if defined(TC_SPARC)
enum reloc_type
{
@@ -303,11 +301,11 @@ struct nlist
/* The following enum and struct were borrowed from SunOS's
/usr/include/sun4/a.out.h and extended to handle
- other machines. It is currently used on SPARC and AMD 29000.
+ other machines. It is currently used on SPARC.
reloc_ext_bytes is how it looks on disk. reloc_info_extended is
how we might process it on a native host. */
-#if USE_EXTENDED_RELOC
+#if defined(TC_SPARC)
struct reloc_ext_bytes
{
@@ -406,7 +404,7 @@ struct reloc_std_bytes
#define RELOC_STD_SIZE 8 /* Bytes per relocation
entry */
-#endif /* USE_EXTENDED_RELOC */
+#endif /* TC_SPARC */
#ifndef CUSTOM_RELOC_FORMAT
struct relocation_info