This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] [GOLD] Add plugin API for processing plugin-added input files
- From: Stephen Crane <sjc at immunant dot com>
- To: Cary Coutant <ccoutant at gmail dot com>
- Cc: Sriraman Tallam <tmsriram at google dot com>, Binutils <binutils at sourceware dot org>
- Date: Tue, 7 Nov 2017 16:39:21 -0800
- Subject: Re: [PATCH] [GOLD] Add plugin API for processing plugin-added input files
- Authentication-results: sourceware.org; auth=none
- References: <CAB7K5r44EtJiXZOiQzM+qqymKjooOTbyb7gikfOxbk7yoyrywg@mail.gmail.com> <CAAs8HmyFiWr6SKG-p+_zHGVBw7sSAoudO5b0qe_zaVPLK1HGmw@mail.gmail.com> <CAB7K5r4DaPN+bq=evZv5zmiEA3BQ8RCv-8ex6889J-AyNyCxdA@mail.gmail.com> <CAAs8HmxEMuOn=cjKOn_gNRv0ve4yshvt2VwLJAasq7d4fVc0Kg@mail.gmail.com> <CAJimCsGtFxP9uNivzrz_uV=V7FyznbzDAE8ZTKRR_+wPdJHO5A@mail.gmail.com> <87376dlcb9.fsf_-_@immunant.com>
Just wanted to ping this patch and see who would be the appropriate
person to approve if it's good to go.
Thanks,
Stephen
On Fri, Oct 20, 2017 at 2:49 PM, Stephen Crane <sjc@immunant.com> wrote:
>
> A single test script sounds good to me. Attached is an updated and
> rebased patch using a unified test script. I added the failing input
> file to the test output to make it clear in the log which test failed.
>
> gold/Changelog:
>
> * plugin.cc (Plugin::load): Include hooks for register_new_input
> in transfer vector.
> (Plugin::new_input): New function.
> (register_new_input): New function.
> (Plugin_manager::claim_file): Call Plugin::new_input if in
> replacement phase.
> * plugin.h (Plugin::set_new_input_handler): New function.
> * testsuite/plugin_new_section_layout.c: New plugin to test
> new_input plugin API.
> * testsuite/plugin_final_layout.sh: Add new input test.
> * testsuite/Makefile.am (plugin_layout_new_file): New test case.
> * testsuite/Makefile.in: Regenerate.
>
> - stephen
>