Re: New regressions in GAS testsuite for arm-wince-pe

[Thomas Preudhomme <thomas dot preudhomme at foss dot arm dot com>]

Hi,

Object files other than ELF do not have mapping symbols to indicate the type of 
data for objdump to work reliably. This is why the following tests FAIL on 
arm-wince-pe targets:
ARMv6T2 Thumb CoProcessor Instructions (1)
ARMv6T2 Thumb CoProcessor Instructions (2)

This patch adds the force-thumb disassembler option to objdump for this test to 
PASS on these targets as well.

ChangeLog entry is as follows:

*** gas/ChangeLog ***

2017-11-02  Thomas Preud'homme  <thomas.preudhomme@arm.com>

    * testsuite/gas/arm/copro-thumb_v6t2plus-thumb_v6t2-1.d: Add
    --disassembler-options=force-thumb to objdump options.
    * testsuite/gas/arm/copro-thumb_v6t2plus-thumb_v6t2-2.d: Likewise.

Committed as obvious.

Best regards,

Thomas


On 01/11/17 16:15, Thomas Preudhomme wrote:
> I'll have a look at why they fail first if you don't mind. I find it curious 
> that the disassembly is different (yet the same instructions were assembled).
>
> Best regards,
>
> Thomas
>
> On 01/11/17 12:28, Nick Clifton wrote:
> > Hi Thomas,
> >
> >    I am seeing some new regressions in the GAS testsuite for the
> >    arm-wince-pe target:
> >
> >      GAS REGRESSION: ARMv6T2 Thumb CoProcessor Instructions (1)
> >      GAS REGRESSION: ARMv6T2 Thumb CoProcessor Instructions (2)
> >
> >    Please could you add a skip or xfail for this particular
> >    configuration ?  A patch to do so is pre-approved.
> >
> > Cheers
> >    Nick
diff --git a/gas/ChangeLog b/gas/ChangeLog
index 82e5580..ce1a97a 100644
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,3 +1,9 @@
+2017-11-02  Thomas Preud'homme  <thomas.preudhomme@arm.com>
+
+	* testsuite/gas/arm/copro-thumb_v6t2plus-thumb_v6t2-1.d: Add
+	--disassembler-options=force-thumb to objdump options.
+	* testsuite/gas/arm/copro-thumb_v6t2plus-thumb_v6t2-2.d: Likewise.
+
 2017-11-01  James Bowman  <james.bowman@ftdichip.com>
 
 	* config/tc-ft32.c (md_assemble): Add relaxation reloc
diff --git a/gas/testsuite/gas/arm/copro-thumb_v6t2plus-thumb_v6t2-1.d b/gas/testsuite/gas/arm/copro-thumb_v6t2plus-thumb_v6t2-1.d
index 974cecc..55c6967 100644
--- a/gas/testsuite/gas/arm/copro-thumb_v6t2plus-thumb_v6t2-1.d
+++ b/gas/testsuite/gas/arm/copro-thumb_v6t2plus-thumb_v6t2-1.d
@@ -1,5 +1,5 @@
 #source: copro-arm_v2plus-thumb_v6t2plus.s
-#objdump: -dr --prefix-addresses --show-raw-insn
+#objdump: -dr --prefix-addresses --show-raw-insn --disassembler-options=force-thumb
 #name: ARMv6T2 Thumb CoProcessor Instructions (1)
 #as: -march=armv6t2 -mthumb -mimplicit-it=always -EL
 
diff --git a/gas/testsuite/gas/arm/copro-thumb_v6t2plus-thumb_v6t2-2.d b/gas/testsuite/gas/arm/copro-thumb_v6t2plus-thumb_v6t2-2.d
index 4d5a8e7..e31536e 100644
--- a/gas/testsuite/gas/arm/copro-thumb_v6t2plus-thumb_v6t2-2.d
+++ b/gas/testsuite/gas/arm/copro-thumb_v6t2plus-thumb_v6t2-2.d
@@ -1,5 +1,5 @@
 #source: copro-arm_v5plus-thumb_v6t2plus.s
-#objdump: -dr --prefix-addresses --show-raw-insn
+#objdump: -dr --prefix-addresses --show-raw-insn --disassembler-options=force-thumb
 #name: ARMv6T2 Thumb CoProcessor Instructions (2)
 #as: -march=armv6t2 -mthumb -EL