This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH v2] RISC-V: Fix disassembly of c.addi4spn, c.addi16sp, c.lui when imm=0
- From: Nick Clifton <nickc at redhat dot com>
- To: Palmer Dabbelt <palmer at dabbelt dot com>, binutils at sourceware dot org
- Cc: Andrew Waterman <andrew at sifive dot com>
- Date: Tue, 24 Oct 2017 17:42:23 +0100
- Subject: Re: [PATCH v2] RISC-V: Fix disassembly of c.addi4spn, c.addi16sp, c.lui when imm=0
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=nickc at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A0410C04AC59
- References: <20171024163430.18844-1-palmer@dabbelt.com>
Hi Palmer,
> opcodes/ChangeLog
>
> 2017-10-20 Andrew Waterman <andrew@sifive.com>
>
> * riscv-opc.c (match_c_addi16sp) : New function.
> (match_c_addi4spn): New function.
> (match_c_lui): Don't allow 0-immediate encodings.
> (riscv_opcodes) <addi>: Use the above functions.
> <add>: Likewise.
> <c.addi4spn>: Likewise.
> <c.addi16sp>: Likewise.
>
> gas/ChangeLog
>
> 2017-10-24 Andrew Waterman <andrew@sifive.com>
>
> * gas/testsuite/gas/riscv/c-addi16sp-fail.d: New test.
> gas/testsuite/gas/riscv/c-addi16sp-fail.l: Likewise.
> gas/testsuite/gas/riscv/c-addi16sp-fail.s: Likewise.
> gas/testsuite/gas/riscv/c-addi4spn-fail.d: Likewise.
> gas/testsuite/gas/riscv/c-addi4spn-fail.l: Likewise.
> gas/testsuite/gas/riscv/c-addi4spn-fail.s: Likewise.
> testsuite/gas/riscv/riscv.exp: Add new tests.
Approved - please apply - except that the gas ChangeLog entry
does need the "gas/" prefix to the filenames...
Cheers
Nick