Re: [PATCH] LVU: dump loclists with locviews

[Alan Modra <amodra at gmail dot com>]

Reposting, since I discovered all the emails I tried to send while at
the cauldron disappeared..

On Mon, Sep 04, 2017 at 09:50:39PM -0300, Alexandre Oliva wrote:
> On Aug 29, 2017, Alan Modra <amodra@gmail.com> wrote:
>
> > On Fri, Aug 18, 2017 at 10:33:13AM -0300, Alexandre Oliva wrote:
> >> Tested on x86_64-linux-gnu.  Ok to install?
>
> > Patches like this need testing on a larger set of targets.
>
> Ugh, yes indeed, my apologies.  As much as I thought I had adjusted the
> GCC output to look like the other dwarf dumping test, so as to make it
> portable, evidently I missed a few details that made it not as
> portable.  "I only proved the code ought to work, but I didn't test it" :-D
> Sorry, I shall learn eventually ;-)
>
> The problems I found out by proper(er?) testing were:
>
> - using '#' for comments; turned into /**/
>
> - using .section directives with more than just the section name;
>   dropped flags and @type

The '@' is the problem.  It starts a comment on ARM.

> This patch was tested on x86_64-linux-gnu (again), sh-elf, arm-eabi,
> mips64-elf, and sh-pe.  Does that seem like enough coverage, or would
> you suggest any further targets?  (I hope by listing the failures in all
> those targets you were not suggesting me to test on all of them, but if
> that's the case, I guess I could make arrangements to do so :-)

Yeah, I was meaning for you to investigate the failures on all those
targets.  With the latest patch you're down to

mn10200-elf  +FAIL: readelf --debug-dump=loc
nds32le-elf  +FAIL: readelf --debug-dump=loc
riscv32-elf  +FAIL: readelf --debug-dump=loc (reason: unexpected output)
riscv32-elf  +ERROR:
/home/alan/src/binutils-gdb/binutils/testsuite/binutils-all/locview-2.s:
assembly failed
riscv32-elf  +ERROR: could not assemble locview-2 test file
riscv32-elf  +FAIL: readelf --debug-dump=loc
riscv64-elf  +FAIL: readelf --debug-dump=loc (reason: unexpected output)
riscv64-elf  +ERROR:
/home/alan/src/binutils-gdb/binutils/testsuite/binutils-all/locview-2.s:
assembly failed
riscv64-elf  +ERROR: could not assemble locview-2 test file
riscv64-elf  +FAIL: readelf --debug-dump=loc
xtensa-elf  +FAIL: readelf --debug-dump=loc

A couple of those can be fixed, I think, by adding #... in the right
place in your .d file, the others should be xfailed.  OK with those
changes.

-- 
Alan Modra
Australia Development Lab, IBM